DINH Viet Hoa
2003-Nov-20 16:38 UTC
[Dovecot] patch and bug report (from an other in fact)
When messages marked \Recent are deleted and expunged, the patch now sends the new message count and the new recent messages count (although the message count is not really necessary).>From RFC 3501 errata (ftp://ftp.cac.washington.edu/imap/rfc3501-errata)<< Section 6.4.3, page 49: old: The EXPUNGE command permanently removes all messages that have the \Deleted flag set from the currently selected mailbox. Before returning an OK to the client, an untagged EXPUNGE response is sent for each message that is removed. new: The EXPUNGE command permanently removes all messages that have the \Deleted flag set from the currently selected mailbox. Before returning an OK to the client, an untagged EXPUNGE response is sent for each message that is removed. Note that if any messages with the \Recent flag set are expunged, an untagged RECENT response is sent after the untagged EXPUNGE(s) to update the client's count of RECENT messages.>>The bug is that when we connect to the IMAP server through a command (ssh /usr/libexec/imap for example). \Recent flags are not removed when we have finish the access to the mailbox. (I have not yet investigated about that) Besides that, did you found a solution for the message parser ? (the bug in FETCH ENVELOPE that I noticed personnaly to Timo) -- DINH V. Hoa, "s/^\(\(\\.\|[^\[]\|\[\(\^.\|[^^]\)[^]]*\]\)*\)\(\\[^\*[]\)/\1\\\4/" -- St?phane CHAZELAS -------------- next part -------------- A non-text attachment was scrubbed... Name: diff-result Type: application/octet-stream Size: 4880 bytes Desc: not available URL: <http://dovecot.org/pipermail/dovecot/attachments/20031120/7a13dc28/attachment-0001.obj>
Timo Sirainen
2003-Nov-20 17:44 UTC
[Dovecot] patch and bug report (from an other in fact)
On Thu, 2003-11-20 at 18:38, DINH Viet Hoa wrote:> When messages marked \Recent are deleted and expunged, the patch now > sends the new message count and the new recent messages count (although > the message count is not really necessary).Yes, I noticed your mail in imap-list. :) The patch is wrong though, your session may see expunges made by another client as well. More correct location would be lib-storage/index/maildir/maildir-expunge.c, same for mbox, and lib-storage/index/index-sync.c:index_storage_sync_modifylog(). They could check if any \Recent messages were expunged, and if so then call storage->callbacks->new_messages().> The bug is that when we connect to the IMAP server through a command > (ssh /usr/libexec/imap for example). \Recent flags are not removed when we > have finish the access to the mailbox. (I have not yet investigated about > that)Recent counters are completely broken currently.. I had an idea how to fix them to work nicely, but haven't yet had time for that. http://www.washington.edu/imap/listarch/current/msg01039.html> Besides that, did you found a solution for the message parser ? > (the bug in FETCH ENVELOPE that I noticed personnaly to Timo)Solution is to rewrite lib-mail/message-address.c to work with string directly instead of tokens. Haven't done that yet either. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://dovecot.org/pipermail/dovecot/attachments/20031120/5f18fc2b/attachment-0001.bin>