rsync - Mar 2009 - DO NOT REPLY [Bug 6169] New: Syntax Error in runtests.sh "ssh-basic.test" script

https://bugzilla.samba.org/show_bug.cgi?id=6169

           Summary: Syntax Error in runtests.sh "ssh-basic.test"
script
           Product: rsync
           Version: 3.0.5
          Platform: x86
        OS/Version: Other
            Status: NEW
          Severity: minor
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: reiner.schulz@gmx.de
         QAContact: rsync-qa@samba.org


OS: SCO_SV imsprod 3.2 5.0.7 i386

rsync-3.0.5/testsuite/ssh-basic.test
Line 21
Original: if ! [ "`$SSH -o'BatchM...
my change: if [ ! "`$SSH -o'BatchM...

NOT-Operator at wrong place.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6169


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from wayned@samba.org  2009-03-06 09:19 CST -------
Whatever shell that is is broken, because '[' is just a program name
(though
often a built-in these days), and the syntax, "if ! program; then ...
fi" is
legal.  However, that "if" was a bit convoluted with a ! prior to an
equality
comparison, and I changed it into an inequality comparison without the prefixed
"!".

Thanks!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.