llvm dev - Mar 2013 - [LLVMdev] [RFC] TileGX, a new backend for Tilera's many core processor

On Thu, Mar 7, 2013 at 6:33 PM, Jiong Wang <jiwang at tilera.com>
wrote:
> Hi all,
>
> Updated the patches for TILE-Gx backend:
>
> 1. added initial regression tests for tilegx codegen.
> 2. added initial regression tests for MC Layer.
> 3. fixed those commenting style issues.
>
> please review, thanks.
This is a huge patch, and reviewing it in tar.gz is hard.  To
facilitate review process, you can upload this to phabricator.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at
gmail.com>*/

On 03/08/2013 04:48 AM, Dmitri Gribenko wrote:
> On Thu, Mar 7, 2013 at 6:33 PM, Jiong Wang <jiwang at tilera.com>
wrote:
>> Hi all,
>>
>> Updated the patches for TILE-Gx backend:
>>
>> 1. added initial regression tests for tilegx codegen.
>> 2. added initial regression tests for MC Layer.
>> 3. fixed those commenting style issues.
>>
>> please review, thanks.
> This is a huge patch, and reviewing it in tar.gz is hard.  To
> facilitate review process, you can upload this to phabricator.
   OK, I am requesting for a phabricator account.

   one other things is,  should I split the patch into several parts? like

   [PATCH 1/10]
   [PATCH 2/10]
    ...

   because clang patch & test-suite patch is relatively small, but llvm 
patch is nearly 10K line, still hard to review.

   if it is, will one patch for one file OK?

   What's the patch policy in llvm community ?

   thanks

---
Regards,
Jiong
>
> Dmitri
>

-- 
Regards,
Jiong. Wang
Tilera Corporation.

On Mar 8, 2013, at 2:31 AM, Jiong Wang <jiwang at tilera.com> wrote:
> On 03/08/2013 04:48 AM, Dmitri Gribenko wrote:
>> On Thu, Mar 7, 2013 at 6:33 PM, Jiong Wang <jiwang at tilera.com>
wrote:
>>> Hi all,
>>> 
>>> Updated the patches for TILE-Gx backend:
>>> 
>>> 1. added initial regression tests for tilegx codegen.
>>> 2. added initial regression tests for MC Layer.
>>> 3. fixed those commenting style issues.
>>> 
>>> please review, thanks.
>> This is a huge patch, and reviewing it in tar.gz is hard.  To
>> facilitate review process, you can upload this to phabricator.
> 
>  OK, I am requesting for a phabricator account.
> 
>  one other things is,  should I split the patch into several parts? like
> 
>  [PATCH 1/10]
>  [PATCH 2/10]
>   ...
> 
>  because clang patch & test-suite patch is relatively small, but llvm
patch is nearly 10K line, still hard to review.
> 
>  if it is, will one patch for one file OK?
> 
>  What's the patch policy in llvm community ?
> 
Hi Jiong,

The LLVM community prefers small, self-contained patches. Please split up your
patches into small chunks that can be easily reviewed. Keep in mind that the
compiler needs to work after each pass goes in. :-)

-bw