Woller, Thomas
2006-Mar-01 19:18 UTC
[Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic
Svm patch to add 32bit msr support (combined both 32bit with 64bit functions) and enable vlapic for 64bit. Applies cleanly to 9023. Please apply. Signed-off-by: Tom Woller <thomas.woller@amd.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Aron Griffis
2006-Mar-02 01:10 UTC
Re: [Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic
Content-Description: svm_msr32_vlapic.patch> +#ifdef __x86_64__ > HVM_DBG_LOG(DBG_LEVEL_2, "mode_do_msr_read: msr_content: %lx\n", > msr_content); > +#else > + HVM_DBG_LOG(DBG_LEVEL_2, "mode_do_msr_read: msr_content: %llx\n", > + msr_content); > +#endifCould these simply use %llx and get rid of the #ifdef? %llx is 64-bit on x86 and x86_64 -- Aron Griffis hp Open Source & Linux Organization R&D _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Mar-02 08:28 UTC
Re: [Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic
On 2 Mar 2006, at 01:10, Aron Griffis wrote:>> +#ifdef __x86_64__ >> HVM_DBG_LOG(DBG_LEVEL_2, "mode_do_msr_read: msr_content: %lx\n", >> msr_content); >> +#else >> + HVM_DBG_LOG(DBG_LEVEL_2, "mode_do_msr_read: msr_content: %llx\n", >> + msr_content); >> +#endif > > Could these simply use %llx and get rid of the #ifdef? %llx is 64-bit > on x86 and x86_64Should be PRIu64. I can make that simple cleanup... -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Seemingly Similar Threads
- [PATCH] check before relinquishing vlapic because VMX domain may crash very early
- [PATCH][SVM] remove FFXSR CPUID bit for AMD-V HVM guests
- [PATCH]x86:vlapic: Fix possible guest tick losing after save/restore
- [PATCH] Nested VMX: Expose unrestricted guest feature to guest
- [PATCH] pygrub: look harder for elilo.conf