Xen devel - Dec 2010 - [PATCH]x86:vlapic: Fix possible guest tick losing after save/restore

x86:vlapic: Fix possible guest tick losing after save/restore

Guest vcpu may totally lose all ticks if the vlapic->pt.irq was not restored
during save/restore process. Fix it.

Signed-off-by: Wei Gang <gang.wei@intel.com>

diff -r 0892f5a96736 xen/arch/x86/hvm/vlapic.c
--- a/xen/arch/x86/hvm/vlapic.c	Fri Dec 10 15:19:51 2010 +0800
+++ b/xen/arch/x86/hvm/vlapic.c	Fri Dec 10 15:27:11 2010 +0800
@@ -955,12 +955,12 @@ static void lapic_rearm(struct vlapic *s
     unsigned long tmict = vlapic_get_reg(s, APIC_TMICT);
     uint64_t period;
 
+    s->pt.irq = vlapic_get_reg(s, APIC_LVTT) & APIC_VECTOR_MASK;
     if ( (tmict = vlapic_get_reg(s, APIC_TMICT)) == 0 )
         return;
 
     period = ((uint64_t)APIC_BUS_CYCLE_NS *
               (uint32_t)tmict * s->hw.timer_divisor);
-    s->pt.irq = vlapic_get_reg(s, APIC_LVTT) & APIC_VECTOR_MASK;
     create_periodic_time(vlapic_vcpu(s), &s->pt, period,
                          vlapic_lvtt_period(s) ? period : 0,
                          s->pt.irq,


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel