rsync - Mar 2005 - [Bug 2408] when more than --max-delete files are about to be deleted no error is returned

https://bugzilla.samba.org/show_bug.cgi?id=2408





------- Additional Comments From arthur@west.nl  2005-03-02 08:28 -------
Created an attachment (id=1003)
 --> (https://bugzilla.samba.org/attachment.cgi?id=1003&action=view)
patch to limit the number of deletes before the deletes take place

Ok, uploaded the patch as a file instead of the comment of the orriginal
report.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2408


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From wayned@samba.org  2005-03-02 20:11 -------
I agree that rsync should output some kind of warning and return code when it
hits the --max-delete limit.  Adding an extra delete-counting pass would be
pretty slow for large file sets, so if that gets added it would need to be an
option.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2408





------- Additional Comments From arthur@west.nl  2005-03-03 01:23 -------
I don't know if there is an easy check to figure out how many files would be
deleted (my patch is a very naive implementation). I understand that the
--delete-during option would make this more difficult though.

Any chance that the warning and return code will be in the next release?

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2408


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2005-03-06 00:02 -------
I have updated the source in CVS so that it complains at the end of the run and
returns a new status code (25) when the max-delete value is exceeded.  It also
mentions how many deletions were skipped.  This will let you run rsync with
--dry-run --max-delete=1 to see a count of the number of deleted files minus
one. I don't have any plans to make rsync check the delete count
automatically
before starting the deletions.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2408





------- Additional Comments From arthur@west.nl  2005-03-07 01:17 -------
Thanks. If it is important enough for us, I may consider writing a patch. Maybe
it is a good idea to document this in the manual page. Maybe something like:

--max-delete=NUM
This  tells  rsync not to delete more than NUM files or directories. This is
useful when mirroring very large trees to prevent disasters. Attempting to
delete more files or directories will result in an error message and a non-zero
exit code.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.