rsync - Jun 2006 - DO NOT REPLY [Bug 3824] New: Max-delete with percentage

https://bugzilla.samba.org/show_bug.cgi?id=3824

           Summary: Max-delete with percentage
           Product: rsync
           Version: 2.6.8
          Platform: All
        OS/Version: Windows XP
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: james@rcpt.to
         QAContact: rsync-qa@samba.org


Max-delete currently takes a number of files as a bound on deletions. Would be
nice that if a % character is on this number, then we have max delete as a
percentage of files on the deleting side to be removed (eg, rsync -a
source::dir/ dest/ --max-delete=10%).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3824





------- Comment #1 from hashproduct+rsync@gmail.com  2006-06-06 17:28 MST
-------
A percentage --max-delete would be difficult to implement.  The generator would
need to know the total number of files in the target directory in order to
decide whether to delete or skip deleting the first extraneous file.  The files
could be counted in a separate pass during startup and deleted during the main
pass, or they could be counted during the main pass for deletion in a separate
pass at the end of the transfer.

Do you have a specific case in which a percentage --max-delete would be useful?
  If not, the above sounds like a lot of mess for a minor improvement.

Instead, a numeric max-delete could be calculated from a percentage outside of
rsync using a find command:
  rsync <options> src/ dest/ \
    --max-delete=$(($(find dest/ -printf x | wc -c)*$percent/100))
It would take more work to omit files protected from deletion by filters from
the total.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3824


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




------- Comment #2 from wayned@samba.org  2006-10-15 13:11 MST -------
I'd rather not add this.  Thanks for the idea, though.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.