rsync - Jul 2006 - DO NOT REPLY [Bug 3929] New: after upgrade from 2.6.6 to 2.6.7 --delete is not functional

https://bugzilla.samba.org/show_bug.cgi?id=3929

           Summary: after upgrade from 2.6.6 to 2.6.7 --delete is not
                    functional
           Product: rsync
           Version: 2.6.7
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: jiri.reischig@ecn.cz
         QAContact: rsync-qa@samba.org


After upgrade from 2.6.6 to 2.6.7 --delete is not functional - deleted files on
source server is not deleted in destination directory. 
Before upgrade and after upgrade I use the same command.
I was use rsync to backup whole server with this command:
"rsync -aRHvzh -e ssh --delete --delete-excluded --force --numeric-ids
--exclude-from=exclude-file server-name:/ /var/backup/backup-dir"

There is about 50 GB file size on the backuped server.

When I try backup about ten files and dirs with this command:
"rsync -aRHvzh -e ssh --delete --delete-excluded --force --numeric-ids
--exclude-from=exclude-file server-name:/home/user/ /var/backup/backup-dir"
deleted files on source server was deleted on destination directory.

May be, there is some problem with a lot of files.

I try also 2.6.8 version on both servers but with the same problem.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3929


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #1 from wayned@samba.org  2006-08-12 11:20 MST -------
Please attach the exclude-file list so that I can check to see if I have fixed
this bug or not.  I just found a bug in the exclude code when --relative (-R)
is in effect.

Note that using -R with a source path of "/" has no effect (other than
making
rsync more buggy), so you should be able to get this to work by just dropping
the -R from your first command.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3929





------- Comment #2 from wayned@samba.org  2006-08-12 11:24 MST -------
Created an attachment (id=2091)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2091&action=view)
Fixed an exclude bug with --relative

There was a problem where the "/" could get excluded when --relative
is in
effect.  This patch fixes this.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3929





------- Comment #3 from jiri.reischig@ecn.cz  2006-08-15 05:22 MST -------
Thank you for your help.

I try your patch on both servers (rsync version 2.6.8) without solution with my
problem.

When I downgrade rsync to verion 2.6.6 on my client server (on server is 2.6.8
version) files are deleted on backup server.

There is my exclude file:

/cdrom/?*
/floppy/?*
**/lost+found/?*
/mnt/*?
/proc/?*
/sys/?*
/tmp/?*
/var/tmp/?*
/initrd/proc/?*
/var/spool/squid/**
/var/spool/up2date/**
/var/cache/yum/**
/SWAP
/usr/src/redhat/BUILD/**
/var/log/ipacct/*
/home/home-old/**
/home/*/noBackup/**
/home/*/Drives/**
/home/*/.kde/share/cache/**
/home/*/.netscape/cache/**
/home/*/.galeon/mozilla/galeon/Cache/**
/home/*/.mozilla/*/*/Cache/**
/home/*/.opera/cache4/**
/home/**/*.mp3
/home/**/*.mpg
/home/**/*.wav
/home/**/*.avi


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3929





------- Comment #4 from wayned@samba.org  2006-08-26 11:03 MST -------
Created an attachment (id=2106)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2106&action=view)
Fix the problem with --delete --relative

This patch fixes the problem you're experiencing.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3929


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #5 from wayned@samba.org  2006-08-26 11:04 MST -------
I've checked-in the fix.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3929





------- Comment #6 from jiri.reischig@ecn.cz  2006-08-29 03:46 MST -------
You are right, the 2nd patch resolve my problem.

Thank you very much.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.