Rails spinoffs - Mar 2006 - [Fwd: [PATCH] Allow generic autocompleter (Ajax.Watcher)]

Patch to allow generic Ajax.Autocompleter-style textbox watchers.

Forwarded for "[Rails-spinoffs] Delayed input posting"

-Rob


_______________________________________________
Rails-spinoffs mailing list
Rails-spinoffs-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org
http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs

On 3/1/06, Robin Haswell
<rob-gyMb1R/nBgNh8AIihN9Rc9BPR1lH4CV8@public.gmane.org>
wrote:
> Patch to allow generic Ajax.Autocompleter-style textbox watchers.
Looks good. But check this:

this.hasFocus is never used.
In onObserverEvent, check if the value has really changed since the
last remote call (user might have just moved the caret or he might
have reverted his changes). No need to hit the server in that case.

Yeah it was a typical "get it working and clean it up as you go along"
job. If I re-visit that code any time soon I''ll take your suggestions
onboard and submit another patch.

-Rob

Martin Bialasinski wrote:
> On 3/1/06, Robin Haswell
<rob-gyMb1R/nBgNh8AIihN9Rc9BPR1lH4CV8@public.gmane.org> wrote:
> 
>>Patch to allow generic Ajax.Autocompleter-style textbox watchers.
> 
> 
> Looks good. But check this:
> 
> this.hasFocus is never used.
> In onObserverEvent, check if the value has really changed since the
> last remote call (user might have just moved the caret or he might
> have reverted his changes). No need to hit the server in that case.
> _______________________________________________
> Rails-spinoffs mailing list
> Rails-spinoffs-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org
> http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs

On 3/2/06, Robin Haswell
<rob-gyMb1R/nBgNh8AIihN9Rc9BPR1lH4CV8@public.gmane.org>
wrote:
> Yeah it was a typical "get it working and clean it up as you go
along"
> job. If I re-visit that code any time soon I''ll take your
suggestions
> onboard and submit another patch.
Quoth the Robin:  "I can find you the patch but it won''t make a
lot of
sense to you, I''d ask the dev team to put my patch in to the CVS, then
get a copy of it."

(And ... here comes another controversial statement by Todd!)

I think you need to clean up your patch before the dev team should
even consider putting it into SVN.

(... flame on!)

Todd

And I think, that if someone submitted a wanted to feature to MY
project, I''d be happy to remove some unwanted variables and run a regex
to fix the whitespace in return for the code.

I get paid to write code, I don''t get paid to fix whitespace in patches
for code under licenses that don''t even require me to return my
modifications.

-Rob

Todd Ross wrote:
> On 3/2/06, Robin Haswell
<rob-gyMb1R/nBgNh8AIihN9Rc9BPR1lH4CV8@public.gmane.org> wrote:
> 
>>Yeah it was a typical "get it working and clean it up as you go
along"
>>job. If I re-visit that code any time soon I''ll take your
suggestions
>>onboard and submit another patch.
> 
> 
> Quoth the Robin:  "I can find you the patch but it won''t make
a lot of
> sense to you, I''d ask the dev team to put my patch in to the CVS,
then
> get a copy of it."
> 
> (And ... here comes another controversial statement by Todd!)
> 
> I think you need to clean up your patch before the dev team should
> even consider putting it into SVN.
> 
> (... flame on!)
> 
> Todd
> _______________________________________________
> Rails-spinoffs mailing list
> Rails-spinoffs-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org
> http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs