llvm dev - Jan 2018 - computeKnownBits doesn't handle ISD::ConstantFP

SelectionDAG's computeKnownBits has no case for ConstantFP, e.g. Known.ones
= cast <ConstantFPSDNode>(Op)->getValueAFP ().bitcastToAPInt ();

I can't easily override this in target specific code. Can anyone see an
issue with submitting the patch to upstream?

Suggestions for an in tree target that could trigger this would be very
welcome.

Cheers
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180119/a47d9539/attachment.html>

On 1/19/2018 4:01 AM, Jon Chesterfield via llvm-dev
wrote:
> SelectionDAG's computeKnownBits has no case for ConstantFP, e.g. 
> Known.ones = cast <ConstantFPSDNode>(Op)->getValueAFP 
> ().bitcastToAPInt ();
This was added in https://reviews.llvm.org/rL316831 .

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project

That's very good. We're clearly further from head of dev than I
realised!

Thanks for the link.

On 19 Jan 2018 18:53, "Friedman, Eli" <efriedma at
codeaurora.org> wrote:

On 1/19/2018 4:01 AM, Jon Chesterfield via llvm-dev wrote:
> SelectionDAG's computeKnownBits has no case for ConstantFP, e.g.
> Known.ones = cast <ConstantFPSDNode>(Op)->getValueAFP
().bitcastToAPInt
> ();
>
This was added in https://reviews.llvm.org/rL316831 .

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180119/6d2b828a/attachment.html>