Jon Chesterfield via llvm-dev
2018-Jan-19 12:01 UTC
[llvm-dev] computeKnownBits doesn't handle ISD::ConstantFP
SelectionDAG's computeKnownBits has no case for ConstantFP, e.g. Known.ones = cast <ConstantFPSDNode>(Op)->getValueAFP ().bitcastToAPInt (); I can't easily override this in target specific code. Can anyone see an issue with submitting the patch to upstream? Suggestions for an in tree target that could trigger this would be very welcome. Cheers -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180119/a47d9539/attachment.html>
Friedman, Eli via llvm-dev
2018-Jan-19 18:53 UTC
[llvm-dev] computeKnownBits doesn't handle ISD::ConstantFP
On 1/19/2018 4:01 AM, Jon Chesterfield via llvm-dev wrote:> SelectionDAG's computeKnownBits has no case for ConstantFP, e.g. > Known.ones = cast <ConstantFPSDNode>(Op)->getValueAFP > ().bitcastToAPInt ();This was added in https://reviews.llvm.org/rL316831 . -Eli -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Jon Chesterfield via llvm-dev
2018-Jan-19 20:29 UTC
[llvm-dev] computeKnownBits doesn't handle ISD::ConstantFP
That's very good. We're clearly further from head of dev than I realised! Thanks for the link. On 19 Jan 2018 18:53, "Friedman, Eli" <efriedma at codeaurora.org> wrote: On 1/19/2018 4:01 AM, Jon Chesterfield via llvm-dev wrote:> SelectionDAG's computeKnownBits has no case for ConstantFP, e.g. > Known.ones = cast <ConstantFPSDNode>(Op)->getValueAFP ().bitcastToAPInt > (); >This was added in https://reviews.llvm.org/rL316831 . -Eli -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180119/6d2b828a/attachment.html>
Reasonably Related Threads
- computeKnownBits doesn't handle ISD::ConstantFP
- [LLVMdev] Prevent DAG combiner from changing "store ConstFP, addr" to integer store
- [LLVMdev] get unsigned integer pattern for ConstantFP
- [LLVMdev] s/ComputeMaskedBits/ComputeKnownBits/g ?
- [LLVMdev] s/ComputeMaskedBits/ComputeKnownBits/g ?