llvm dev - Jun 2017 - Enabling EarlyCSE w/ MemorySSA by default

Hi All,

I'd like to switch the function simplification run of EarlyCSE to use 
MemorySSA by default.  This change has been in tree for a while and I've 
done benchmark and self-hosting testing on both aarch64 and x86, but I 
wanted to give other folks with different tests/targets a chance to try 
this out before I flip the switch. I've added an option 
'-enable-earlycse-memssa' (or '-enable-npm-gvn-hoist' if
you're using
the new pass manager) that you can be used to test this change out.

Thanks,

-- 
Geoff Berry
Employee of Qualcomm Datacenter Technologies, Inc.
  Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project.

On Sat, Jun 10, 2017 at 8:21 AM, Geoff Berry via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> Hi All,
>
> I'd like to switch the function simplification run of EarlyCSE to use
> MemorySSA by default.  This change has been in tree for a while and
I've
> done benchmark and self-hosting testing on both aarch64 and x86, but I
> wanted to give other folks with different tests/targets a chance to try
this
> out before I flip the switch. I've added an option
'-enable-earlycse-memssa'
> (or '-enable-npm-gvn-hoist' if you're using the new pass
manager) that you
> can be used to test this change out.
>
Not that I don't trust your self-hosting test strategy, but other
passes (e.g. GVNHoist or NewGVN) showed us that's not quite enough to
declare victory. I'll be much more confident if we can do at least a
round of fuzzing.

Thanks,

--
Davide

+1
If possible, it definitely helps to fuzz it.


On Sat, Jun 10, 2017 at 2:45 PM, Davide Italiano via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Sat, Jun 10, 2017 at 8:21 AM, Geoff Berry via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> > Hi All,
> >
> > I'd like to switch the function simplification run of EarlyCSE to
use
> > MemorySSA by default.  This change has been in tree for a while and
I've
> > done benchmark and self-hosting testing on both aarch64 and x86, but I
> > wanted to give other folks with different tests/targets a chance to
try
> this
> > out before I flip the switch. I've added an option
> '-enable-earlycse-memssa'
> > (or '-enable-npm-gvn-hoist' if you're using the new pass
manager) that
> you
> > can be used to test this change out.
> >
>
> Not that I don't trust your self-hosting test strategy, but other
> passes (e.g. GVNHoist or NewGVN) showed us that's not quite enough to
> declare victory. I'll be much more confident if we can do at least a
> round of fuzzing.
>
> Thanks,
>
> --
> Davide
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170610/ee9bcc30/attachment.html>