Renato Golin
2015-Mar-11 14:32 UTC
[LLVMdev] [RFC] Raise minimum required CMake version to 3.0
On 11 March 2015 at 14:07, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:>> 3. Ninja "pool = console" would fix the timeout issues on slow builds, >> but it's not clear how CMake would do that by default > > I'm not sure I understand the second part of that statement. As far as I know, all we have to do is add USES_TERMINAL to the appropriate targets and this change was made in r222181. At this point having CMake >= 3.2 and Ninja >= 1.5 should be enough to make this work.Ok, but CMake 3.2 is *too* new. I'm ok with supporting this on my bots, to fix them properly, but that's not something I'd like to impose on everyone. Thanks for the explanation. cheers, --renato
Daniel Sanders
2015-Mar-11 14:38 UTC
[LLVMdev] [RFC] Raise minimum required CMake version to 3.0
> -----Original Message----- > From: Renato Golin [mailto:renato.golin at linaro.org] > Sent: 11 March 2015 14:33 > To: Daniel Sanders > Cc: Chandler Carruth; jroelofs; LLVM Dev; Tobias Grosser > Subject: Re: [LLVMdev] [RFC] Raise minimum required CMake version to 3.0 > > On 11 March 2015 at 14:07, Daniel Sanders <Daniel.Sanders at imgtec.com> > wrote: > >> 3. Ninja "pool = console" would fix the timeout issues on slow builds, > >> but it's not clear how CMake would do that by default > > > > I'm not sure I understand the second part of that statement. As far as I > know, all we have to do is add USES_TERMINAL to the appropriate targets > and this change was made in r222181. At this point having CMake >= 3.2 and > Ninja >= 1.5 should be enough to make this work. > > Ok, but CMake 3.2 is *too* new. I'm ok with supporting this on my > bots, to fix them properly, but that's not something I'd like to > impose on everyone. > > Thanks for the explanation. > > cheers, > --renatoI agree that it's too new to make it the minimum version. It's just a feature you'll get if CMake is new enough and will gracefully handle older CMake's.
Renato Golin
2015-Mar-11 14:42 UTC
[LLVMdev] [RFC] Raise minimum required CMake version to 3.0
On 11 March 2015 at 14:38, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:> I agree that it's too new to make it the minimum version. It's just a feature you'll get if CMake is new enough and will gracefully handle older CMake's.I imagine that I could add the magic CMake options to my buildbot's configuration on builders.py and locally install CMake 3.2 on them without having to change anyone else's configuration, right? cheers, --renato
Seemingly Similar Threads
- [LLVMdev] [RFC] Raise minimum required CMake version to 3.0
- [LLVMdev] [RFC] Raise minimum required CMake version to 3.0
- [LLVMdev] [RFC] Raise minimum required CMake version to 3.0
- [cfe-dev] [3.8 Release] We have branched
- [LLVMdev] [RFC] Raise minimum required CMake version to 3.0