On Monday 15 February 2010 11:54:25 Óscar Fuentes wrote:> David Greene <dag at cray.com> writes: > > Sorry, I botched a commit and broke the build. I've just committed a > > fix. > > > > So expect to see some buildbot churning. > > Don't hurry. A buildbot already decided that I am the only culprit of > the breakage. :-/Hmm...given that MC/AsmParser/X86/x86_32-encoding.s has been failing for a while, maybe someone should mark it XFAIL? -Dave
On Feb 15, 2010, at 10:00 AM, David Greene wrote:> On Monday 15 February 2010 11:54:25 Óscar Fuentes wrote: >> David Greene <dag at cray.com> writes: >>> Sorry, I botched a commit and broke the build. I've just committed a >>> fix. >>> >>> So expect to see some buildbot churning. >> >> Don't hurry. A buildbot already decided that I am the only culprit of >> the breakage. :-/ > > Hmm...given that MC/AsmParser/X86/x86_32-encoding.s has been failing > for a while, maybe someone should mark it XFAIL?It passed for me until you applied your patch, I reverted it in r96265. -Chris
On Feb 15, 2010, at 12:53 PM, Chris Lattner wrote:> > On Feb 15, 2010, at 10:00 AM, David Greene wrote: > >> On Monday 15 February 2010 11:54:25 Óscar Fuentes wrote: >>> David Greene <dag at cray.com> writes: >>>> Sorry, I botched a commit and broke the build. I've just committed a >>>> fix. >>>> >>>> So expect to see some buildbot churning. >>> >>> Don't hurry. A buildbot already decided that I am the only culprit of >>> the breakage. :-/ >> >> Hmm...given that MC/AsmParser/X86/x86_32-encoding.s has been failing >> for a while, maybe someone should mark it XFAIL? > > It passed for me until you applied your patch, I reverted it in r96265.FWIW, this is because you broke the encoding of an instruction in your patch. This is incorrect: +def MOVNTDQ_64mr : PSI<0xE7, MRMDestMem, (outs), (ins f128mem:$dst, VR128:$src), + "movntdq\t{$src, $dst|$dst, $src}", + [(alignednontemporalstore (v2f64 VR128:$src), addr:$dst)]>; Please don't check in patches when you know that they break testcases. -Chris