Mark Williamson
2007-Jun-29 18:01 UTC
[Xen-devel] [PATCH] [BUGFIX] Disallow save / migrate of a domain with real PCI devices
If a domain has PCI devices then we can''t safely save or migrate it. At least one user has had system crashes due to this, and the way the xendomains script automatically saves and restores domains on reboot. Since there''s no sensible semantics for it at the moment, we should disallow it and return an appropriate error message to xm. The first attached patch prevents the suspend from occurring, the second ensures that the appropriate errors are fed back to the user. Signed-off-by: Mark Williamson <mark.williamson@cl.cam.ac.uk> -- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Petersson, Mats
2007-Jul-02 10:32 UTC
[Xen-devel] RE: [PATCH] [BUGFIX] Disallow save / migrate of a domain with real PCI devices
Looks goog to me - but I''m no expert at those paths... -- Mats> -----Original Message----- > From: M.A. Williamson [mailto:maw48@hermes.cam.ac.uk] On > Behalf Of Mark Williamson > Sent: 29 June 2007 19:01 > To: Keir Fraser > Cc: Ian Campbell; xen-devel@lists.xensource.com; Petersson, Mats > Subject: [PATCH] [BUGFIX] Disallow save / migrate of a domain > with real PCI devices > > If a domain has PCI devices then we can''t safely save or migrate it. > > At least one user has had system crashes due to this, and the way the > xendomains script automatically saves and restores domains on > reboot. Since > there''s no sensible semantics for it at the moment, we should > disallow it and > return an appropriate error message to xm. > > The first attached patch prevents the suspend from occurring, > the second > ensures that the appropriate errors are fed back to the user. > > Signed-off-by: Mark Williamson <mark.williamson@cl.cam.ac.uk> > > -- > Dave: Just a question. What use is a unicyle with no seat? > And no pedals! > Mark: To answer a question with a question: What use is a skateboard? > Dave: Skateboards have wheels. > Mark: My wheel has a wheel! >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel