wine users - Oct 2010 - Re: Performing a Regression Test

Hi, I try to do a regression test for the first time.
I got in some kind of a loop,  it looks like the bad commit isn't removed
I'm stuck

Here's how I went
I found 1 bad commit

7cb044d3d8aaf1cee629c259f19177732bed37af is the first bad commit
commit 7cb044d3d8aaf1cee629c259f19177732bed37af
Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Wed Jul 21 23:56:02 2010 +0200

    sane.ds: Remove the ignored common resource attributes.

:040000 040000 9e1890eada06b83f59052c7b58162c862cdf1681
f9326415ac4094eade2ae554e67f7f9bc88168e2 M	dlls

As said, this MAY NOT be the actual bad commit. 
So I did a make clean & git reset --hard,
Now I get:

HEAD is now at 7cb044d sane.ds: Remove the ignored common resource attributes.

After a ~/wine-git$ git show 7cb044d3d8aaf1cee629c259f19177732bed37af | patch
-p1 -R

I get:

patching file dlls/sane.ds/sane_Da.rc
patching file dlls/sane.ds/sane_De.rc
patching file dlls/sane.ds/sane_En.rc
patching file dlls/sane.ds/sane_Es.rc
patching file dlls/sane.ds/sane_Fi.rc
patching file dlls/sane.ds/sane_Fr.rc
patching file dlls/sane.ds/sane_Hu.rc
patching file dlls/sane.ds/sane_It.rc
patching file dlls/sane.ds/sane_Ja.rc
patching file dlls/sane.ds/sane_Ko.rc
patching file dlls/sane.ds/sane_Lt.rc
patching file dlls/sane.ds/sane_Nl.rc
patching file dlls/sane.ds/sane_No.rc
patching file dlls/sane.ds/sane_Pl.rc
patching file dlls/sane.ds/sane_Pt.rc
patching file dlls/sane.ds/sane_Ro.rc
patching file dlls/sane.ds/sane_Ru.rc
patching file dlls/sane.ds/sane_Si.rc
patching file dlls/sane.ds/sane_Sv.rc
patching file dlls/sane.ds/sane_Uk.rc
patching file dlls/sane.ds/sane_Zh.rc

After ./configure && make deps && make
I test the program again, it doesn't run
so I do again a "git bisect bad"
and it returns to the same bad commit!

How do I remove this commit?
a ~/wine-git$ git show 7cb044d3d8aaf1cee629c259f19177732bed37af | patch -p1 -R
did not remove it?
                                 [Question] 
                                [Rolling Eyes]
Any help is appreciated!

abb4 wrote:
> 
> Any help is appreciated!

Ohh I see,
have to go back to 
git bisect start
git bisect good <wine-tag where program worked>
git bisect bad <wine-tag where program stopped working>


This is quite complicated stuff

> How do I remove this commit?
> a ~/wine-git$ git show 7cb044d3d8aaf1cee629c259f19177732bed37af | patch -p1
-R did not remove it?
You have to look at the output of that command to determine whether it
succeeded. If the affected files have changed since that commit was
made, the revert may not work.

If the revert fails, or reverting on top of a later revision does not
solve the problem, you should recheck your regression result by doing
the following:

$ git bisect reset
in case you're in the middle of a bisect.

$ git reset --hard 7cb044d3d8aaf1cee629c259f19177732bed37af
Rebuild and test. This should be a "bad" revision.

$ git reset --hard 7cb044d3d8aaf1cee629c259f19177732bed37af
Rebuild and test. This should be a "good" revision.

$ git reset --hard origin/master
to get back to the latest revision.

> $ git reset --hard 7cb044d3d8aaf1cee629c259f19177732bed37af
> Rebuild and test. This should be a "good" revision.
Sorry, that command should have had a ^ appended to the end, like this:
$ git reset --hard 7cb044d3d8aaf1cee629c259f19177732bed37af^