Hi! Use #defines for network related default settinsg. Distinguish between default Linux and NetBSD network bridge interfaces. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: minor portability
nits"):> Use #defines for network related default settinsg.
> Distinguish between default Linux and NetBSD network bridge interfaces.
I don''t understand how and when NET_DEFAULT_ADDRESS ought to be set to
something different at compile-time. If what you want is a global
setting, for the administrator to arrange to bind to a particular
address of the host (and you are happy with the security
implications), then I agree that we need a global config file for this
and various other reasons. But not a #define.
> +#define NET_DEFAULT_ADDRESS "127.0.0.1"
> +#if defined(__linux__)
> +#define NET_DEFAULT_BRIDGE "xenbr0"
> +#endif
> +#if defined(__NetBSD__)
> +#define NET_DEFAULT_BRIDGE "bridge0"
> +#endif
This should be in libxl_osdeps.h.
Furthermore, the xenbr0 version should be the default. Ie.
+#ifndef NET_DEFAULT_BRIDGE
+#define NET_DEFAULT_BRIDGE "xenbr0"
+#endif
preceded by some suitable thing for netbsd. Also please use #ifdef
not #if defined(...).
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel