samba - Jun 2005 - Simple fix to horrible bug in Samba website CSS

Dear Folks,

For a long time I have been unable to read the menu at the left of
http://samba.org/ in my 1920x1440 display.  All the menu items
overwrite each other in a horrible, illegible jumble.  I thought it
might be a bug in firefox or something.

Then I investigated, and found that there is actually a serious bug in
the cascading style sheet for the web site.  The problem is in
/samba/style/main.css.  The simple patch makes the menu suddenly
amazingly readable:

$ diff -U5 main.css-orig main.css
--- main.css-orig       2005-06-08 19:19:21.000000000 +1000
+++ main.css    2005-06-08 19:18:55.000000000 +1000
@@ -159,11 +159,11 @@
 }
 .nav a,
 .nav a:link,
 .nav a:visited {
        display:block;
-       height:20px;
+       #height:20px;
        font-size:small;
        color:#2B5C9F;
 }
 .nav a:hover {
        color:#FFF;

Please note that this is not just cosmetic.  For the first time, I
could read the link that allows me to subscribe to the Samba list so
that I can tell you about the problem.

I do not know who is maintaining the CSS, but please could they be
contacted and told about it?
-- 
Nick Urbanik   RHCE       http://nicku.org          nicku(at)nicku.org
Proud ex-member of Dept. of Information & Communications Technology in
Hong Kong IVE (Tsing Yi), Home of Visual Paradigm: Jolt Productivity
Award winner, programmed by ICT's own graduates!
GPG: 7FFA CDC7 5A77 0558 DC7A 790A 16DF EC5B BB9D 2C24    ID: BB9D2C24
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :
http://lists.samba.org/archive/samba/attachments/20050608/7c5f8b8b/attachment.bin

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Nick Urbanik wrote:
| Dear Folks,
|
| For a long time I have been unable to read the menu
| at the left of http://samba.org/ in my 1920x1440
| display.  All the menu items overwrite each other
| in a horrible, illegible jumble.  I thought it
| might be a bug in firefox or something.

I've forward the details onto our webmaster (Deryck Hodge).
He'll probably get back in touch with you since
it sounds to be something specific to your fonts or
setup.  I've never noticed any of the display problems
you describe.








cheers, jerry
====================================================================Alleviating
the pain of Windows(tm)      ------- http://www.samba.org
GnuPG Key                ----- http://www.plainjoe.org/gpg_public.asc
"I never saved anything for the swim back."     Ethan Hawk in Gattaca
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCpua3IR7qMdg1EfYRApMtAKDPhYTEsF1gIvdqxkr/9b0Nyo/7RQCgmuMg
bxFTQYjM6KERXIKzTRkcFXE=1/RX
-----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Nick,

Is this an old message?  I thought we already talked about this?
Deryck, don't you remember a discussion about this?




cheers, jerry

Nick Urbanik wrote:
> On Wed, Jun 08, 2005 at 07:38:15AM -0500, Gerald (Jerry) Carter wrote:
>>Hash: SHA1
>>
>>Nick Urbanik wrote:
>>| Dear Folks,
>>|
>>| For a long time I have been unable to read the menu
>>| at the left of http://samba.org/ in my 1920x1440
>>| display.  All the menu items overwrite each other
>>| in a horrible, illegible jumble.
>>
>>I've forward the details onto our webmaster (Deryck Hodge).
>>He'll probably get back in touch with you
> 
> No, he didn't.
> 
>>since it sounds to be something specific to your fonts or setup.
> 
> Sort of.  I have a 19" monitor at high resolution.  I guess that's
> special.
> 
>>I've never noticed any of the display problems you describe.
> 
> Because you never pressed Ctrl-+ many times in Firefox until the font
> became larger than the fixed size of 20 pixels.
> 
> I have attached two screen images of the menu, one with the default
> CSS, the other with the following simple patch applied.
> 
> $ diff -u main.css-orig main.css
> --- main.css-orig       2005-06-08 19:19:21.000000000 +1000
> +++ main.css    2005-06-08 19:18:55.000000000 +1000
> @@ -161,7 +161,7 @@
>  .nav a:link,
>  .nav a:visited {
>         display:block;
> -       height:20px;
> +       #height:20px;
>         font-size:small;
>         color:#2B5C9F;
>  }
> 
> Trust me, it needs fixing.
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 

- --
====================================================================Alleviating
the pain of Windows(tm)      ------- http://www.samba.org
GnuPG Key                ----- http://www.plainjoe.org/gpg_public.asc
"I never saved anything for the swim back."     Ethan Hawk in Gattaca
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCwq72IR7qMdg1EfYRAi3mAJ0UJxOoZ8JLpMa9H+vtag0Fo2x4TQCfXsMB
P6URtFiEwz2cJTaN3Jt6FqI=lP1K
-----END PGP SIGNATURE-----