samba-bugs at samba.org
2010-Dec-26 22:53 UTC
DO NOT REPLY [Bug 7889] New: Add "--backup-deleted"
https://bugzilla.samba.org/show_bug.cgi?id=7889 Summary: Add "--backup-deleted" Product: rsync Version: 3.0.7 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: jik at kamens.brookline.ma.us QAContact: rsync-qa at samba.org I am using rsync in a way where I very much want deleted destination files to be backed up, but I very much do not want modified destination files to be backed up. In particular, I want to "shred" deleted files, and the easiest way to do that is to give them a backup prefix and then go through all the files with that prefix after rsync is done and shred them. The reason why it is important for me to only back up deleted files is because I am doing rsync to an s3backer filesystem, and my upload bandwidth is low, so if I back up modified files in addition to deleted ones, then rsync has to write a lot more data to the s3backer filesystem, which make the backup run much more slowly and also costs me more money in s3backer usage fees. The fact that I am using s3backer is also why I want to shred (with -z) the deleted files, because if I overwrite them with nulls, the relevant blocks will be deleted on the s3backer filesystem, thus saving me money in s3backer usage fees. I added a new flag to rsync to do what I need: --backup-deleted, which backs up deleted files without backing up modified ones. I think this functionality is generally useful enough that it is worth incorporating into the official rsync distribution. Please note: this introduces a protocol incompatibility, which I have NOT dealt with in my patch, because I don't understand the ins and outs of how this works and I'm pretty sure the rsync maintainers will be able to figure this part out a lot faster and more correctly then I can. I am attaching to this bug report my patch for adding --backup-deleted support. Thank you for considering my patch. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs at samba.org
2010-Dec-26 22:54 UTC
DO NOT REPLY [Bug 7889] Add "--backup-deleted"
https://bugzilla.samba.org/show_bug.cgi?id=7889 ------- Comment #1 from jik at kamens.brookline.ma.us 2010-12-26 16:54 CST ------- Created an attachment (id=6169) --> (https://bugzilla.samba.org/attachment.cgi?id=6169&action=view) patch to add --backup-deleted -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
https://bugzilla.samba.org/show_bug.cgi?id=7889 --- Comment #2 from Jonathan Kamens <jik at kamens.brookline.ma.us> 2011-04-03 05:11:22 UTC --- Would love to hear your thoughts about this feature. Any chance of getting it in? -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
https://bugzilla.samba.org/show_bug.cgi?id=7889 Jonathan Kamens <jik at kamens.brookline.ma.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6169|0 |1 is obsolete| | --- Comment #3 from Jonathan Kamens <jik at kamens.brookline.ma.us> 2011-04-03 05:17:48 UTC --- Created attachment 6368 --> https://bugzilla.samba.org/attachment.cgi?id=6368 new patch (against rsync 3.0.8) to add --backup-deleted -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
https://bugzilla.samba.org/show_bug.cgi?id=7889 Wayne Davison <wayned at samba.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Wayne Davison <wayned at samba.org> 2011-04-09 16:44:21 UTC --- Thanks! I have adapted your patch for 3.1.0dev and put it in the patches directory. I'm considering including it in the 3.1.0 release. Some notes on the changes I made in the official patch: - The option sending was enhanced to send -b to a remote sender, even if the local receiver is using --backup-deleted (making it more backward-compatible). A remote receiver gets both -b and --backup-deleted, which is fine since the latter overrides the former. - Doc changes need to patch rsync.yo (which generates rsync.1). Otherwise everything looked great. The changes are nice and simple, which makes me lean toward accepting this as a new option. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
Apparently Analagous Threads
- [jik@kamens.brookline.ma.us: MSS clamping doesn''t work with masquerading through VPN?]
- patch: properly zeroing fd_set in clientloop
- Timeline for rsync 3.1 release?
- [Bug 1430] New: Restore support for "none" cipher, i.e., unencrypted connections
- Request to Replace Recordplot ,, replayplot