rsync - May 2009 - DO NOT REPLY [Bug 6422] New: rsync needlessly aborts when getcwd() fails

https://bugzilla.samba.org/show_bug.cgi?id=6422

           Summary: rsync needlessly aborts when getcwd() fails
           Product: rsync
           Version: 3.0.6
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: vapier@gentoo.org
         QAContact: rsync-qa@samba.org


rsync will abort if getcwd() fails even though the current working directory is
irrelevant to the request in question

for example, this should not fail:
cd ~/
mkdir -p src dst foo/a/b/c
touch src/a
cd foo/a/b/c
rm -rf ~/foo
rsync -a ~/src/ ~/dst/

that rsync command errors out with:
rsync: getcwd(): No such file or directory (2)
rsync error: errors selecting input/output files, dirs (code 3) at util.c(992)
[receiver=3.0.6]

and looking in ~/dst/, i see no files have been transferred


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6422


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




------- Comment #1 from wayned at samba.org  2009-09-05 10:46 CST -------
There are all sorts of options and args that can depend on the current
directory.  If we allow the determination of what the current directory is to
fail, we'd need to set a flag that the failure happened and then add code to
every case that made sure that if curr_dir was used to construct a path that it
should error out at that point.  I don't think this is worth the complexity.

For scripts, you can add a "cd /" to make sure that your current
directory is
always valid.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6422





------- Comment #2 from vapier at gentoo.org  2009-09-05 16:31 CST -------
i'd agree if i was attempting to do an actual operation on the current
directory (like `rsync -a ./ foo:/`), but when the current directory is wholly
irrelevant, it shouldnt fail imo

i wasnt running scripts, i was running rsync by hand in a terminal


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=6422

--- Comment #3 from Florian Weimer <fweimer at redhat.com> ---
I posted a patch:
https://lists.samba.org/archive/rsync/2018-February/031476.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.