samba-bugs@samba.org
2007-Nov-11 22:08 UTC
DO NOT REPLY [Bug 5074] New: Push to a daemon with --only-write-batch modifies dest and then hangs
https://bugzilla.samba.org/show_bug.cgi?id=5074
Summary: Push to a daemon with --only-write-batch modifies dest
and then hangs
Product: rsync
Version: 3.0.0
Platform: x86
OS/Version: Linux
Status: NEW
Severity: major
Priority: P3
Component: core
AssignedTo: wayned@samba.org
ReportedBy: matt@mattmccutchen.net
QAContact: rsync-qa@samba.org
Using the latest development rsync, if I push files to a daemon with
--only-write-batch, the daemon makes some of the changes to the destination and
then hangs. The run should finish with no changes made to the destination.
To reproduce, run the following in an empty directory:
export PATH=/path/to/rsync/build/tree:$PATH
wget http://mattmccutchen.net/rsync/instant-daemon.sh
sh instant-daemon.sh module 3141 user
(Choose a password and enter it twice)
mkdir upload
ln -s . upload/me
echo foo >upload/file
rsync -rl --only-write-batch=thebatch upload/
rsync://user@localhost:3141/module/
(Enter the password)
(When the process hangs, press ^C)
ls -la module
(Note that the symlink was copied.)
./stop
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2007-Nov-22 19:21 UTC
DO NOT REPLY [Bug 5074] Push to a daemon with --only-write-batch modifies dest and then hangs
https://bugzilla.samba.org/show_bug.cgi?id=5074
wayned@samba.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Comment #1 from wayned@samba.org 2007-11-22 13:21 CST -------
I have checked in a fix for this. Thanks for finding the problem!
Aside: your instant-daemon.sh script should set mode 600 on the secret file or
the daemon might refuse to use it.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Possibly Parallel Threads
- DO NOT REPLY [Bug 5265] New: Daemon logging files not actually received with --only-write-batch
- DO NOT REPLY [Bug 5201] New: Rsync lets user corrupt dest by applying non-inplace batch in inplace mode
- DO NOT REPLY [Bug 5051] New: --copy-dest copies should use a temporary file unless --inplace
- DO NOT REPLY [Bug 7123] New: Use both old dest file and partial file as basis data
- DO NOT REPLY [Bug 5644] New: Option to recheck basis dirs for existing dest files