Aaron Digulla
2007-Oct-15 07:58 UTC
[feature request] Modify --backup option to make backups on source side, too
Hello, Can you please modify the backup options to work together with --remove-source-files so I'm able to create a reliable "move between hosts" script? If --backup is specified, the files to be deleted should be renamed on the source side. If --backup-dir is specified, they should be moved there, etc. If this already works, please update the documentation accordingly :-) Thanks a lot, -- Aaron "Optimizer" Digulla a.k.a. Philmann Dark "It's not the universe that's limited, it's our imagination. Follow me and I'll show you something beyond the limits." http://www.pdark.de/
Matt McCutchen
2007-Oct-15 12:06 UTC
[feature request] Modify --backup option to make backups on source side, too
On 10/15/07, Aaron Digulla <digulla@hepe.com> wrote:> Can you please modify the backup options to work together with > --remove-source-files so I'm able to create a reliable "move between > hosts" script?The patch "patches/source-backup.diff" in the source tree adds an option --source-backup to do this. You can compile your own copy of rsync containing the patch and then use that option. Matt
Matt McCutchen
2007-Oct-15 14:31 UTC
[feature request] Modify --backup option to make backups on source side, too
On 10/15/07, Aaron Digulla <digulla@hepe.com> wrote:> Thanks for the input. If this wasn't for a production system, I'd do > that :-) Why don't you apply the patch the release version?Because the patch is a quick hack to serve a niche need, so the benefit of saving people who need source backups a few steps does not outweigh the cost of having it clutter up (and conceivably destabilize) the main version of rsync for everyone else. I think the model of a main version with the most important features plus distributed patches for various extra features is an excellent way to deliver a clean, stable rsync to the typical user but still have implementations of the extra features available when needed. In fact, beginning in September 2005, I used a copy of rsync including a patch for ACL support for nearly all copies on my computer. The patch was a complete hack and I really cared about ACLs, so I helped Wayne improve the patch to the point where it was just as clean and stable as the main code; then, in March 2007, Wayne elected to roll the patch into the main version. In the same way, I encourage you to test and begin using the source-backup patch now if it suits your needs; if you want the patch added to the main version, you can help make that more likely by improving it. Matt