thr3ads.net - Rails - [Rails] Two quick newbie questions [Mar 2006]

If this information is useful, please help other people find it:
Share via:

Greg

2006-Mar-04 06:01 UTC

[Rails] Two quick newbie questions

2 quick questions regarding authentication ...

1) the flash[:notice] on successful login looks completely wrong to me. 
How should it be done?

  def index
    if request.post?
      @user = User.new(params[:user])
      authentic_user = @user.attempt_login
      if authentic_user
        session[:user_id] = authentic_user.id
        flash[:notice]          ''Login successful! Welcome '' +
authentic_user.first_name + '' '' +
        authentic_user.last_name + ''!''
        redirect_to(:controller => ''user'')
      else
        flash[:notice] = ''Invalid username or password.''
      end
    end
  end

2) can someone explain why the first of these two techniques works (ie, 
login is successful) but the second doesn''t:

@user = User.new(params[:user])
@user = User.new(params[:user => ''username'', :user =>
''password''])

... given this model:

class User < ActiveRecord::Base
  attr_accessor :password
  attr_accessible :username, :password

  def before_create
    self.hashed_password = User.encrypt_password(self.password)
  end

  def after_create
    @password = nil
  end

  def self.login(username, password)
    hashed_password = encrypt_password(password || '''')
    find(:first,
         :conditions => [''username = ? and hashed_password
=?'',
         username, hashed_password])
  end

  def attempt_login
    User.login(self.username, self.password)
  end

  private
  def self.encrypt_password(password)
    Digest::SHA1.hexdigest(password)
  end

end

... and assuming a form with fields ''name=user[username]''
&
''name=user[password]''. Thanks for the help. Kindly
appreciated.

Greg


-- 
Posted via http://www.ruby-forum.com/.

Manish Shah

2006-Mar-04 08:42 UTC

head link

[Rails] Two quick newbie questions

for the 1st question:

I''m fairly new to rails too, but i dont think thats how you concatenate
strings in ruby.  I think you need "<<" where the "+"
is.


for the 2nd question:

params is a hash, and you are referencing the values to the key
"user".  The
second one looks wrong because it seems to be redefining the key
"user" to
two different things, username and password.

When you do User.new(params[:user]), you are passing the hash to the model
to build a new user object.  This would be the same as User.new(:username =>
"foo", :password => "secret", ...)

the call to new is also given a hash.



On 3/3/06, Greg <gmacgregor@gmail.com> wrote:>
>
> 2 quick questions regarding authentication ...
>
> 1) the flash[:notice] on successful login looks completely wrong to me.
> How should it be done?
>
>   def index
>     if request.post?
>       @user = User.new(params[:user])
>       authentic_user = @user.attempt_login
>       if authentic_user
>         session[:user_id] = authentic_user.id
>         flash[:notice]  >         ''Login successful! Welcome
'' + authentic_user.first_name + '' '' +
>         authentic_user.last_name + ''!''
>         redirect_to(:controller => ''user'')
>       else
>         flash[:notice] = ''Invalid username or password.''
>       end
>     end
>   end
>
> 2) can someone explain why the first of these two techniques works (ie,
> login is successful) but the second doesn''t:
>
> @user = User.new(params[:user])
> @user = User.new(params[:user => ''username'', :user
=> ''password''])
>
> ... given this model:
>
> class User < ActiveRecord::Base
>   attr_accessor :password
>   attr_accessible :username, :password
>
>   def before_create
>     self.hashed_password = User.encrypt_password(self.password)
>   end
>
>   def after_create
>     @password = nil
>   end
>
>   def self.login(username, password)
>     hashed_password = encrypt_password(password || '''')
>     find(:first,
>          :conditions => [''username = ? and hashed_password
=?'',
>          username, hashed_password])
>   end
>
>   def attempt_login
>     User.login(self.username, self.password)
>   end
>
>   private
>   def self.encrypt_password(password)
>     Digest::SHA1.hexdigest(password)
>   end
>
> end
>
> ... and assuming a form with fields ''name=user[username]''
&
> ''name=user[password]''. Thanks for the help. Kindly
appreciated.
>
> Greg
>
>
> --
> Posted via http://www.ruby-forum.com/.
> _______________________________________________
> Rails mailing list
> Rails@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails
>-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://wrath.rubyonrails.org/pipermail/rails/attachments/20060304/af509b27/attachment.html

Peter Ertl

2006-Mar-04 08:49 UTC

head link

[Rails] Two quick newbie questions

irb(main):001:0> "XXX" + "123"
=> "XXX123"

> --- Urspr?ngliche Nachricht ---
> Von: "Manish Shah" <mnshah@gmail.com>
> An: rails@lists.rubyonrails.org
> Betreff: Re: [Rails] Two quick newbie questions
> Datum: Sat, 4 Mar 2006 00:42:35 -0800
> 
> for the 1st question:
> 
> I''m fairly new to rails too, but i dont think thats how you
concatenate
> strings in ruby.  I think you need "<<" where the
"+" is.
> 
> 
> for the 2nd question:
> 
> params is a hash, and you are referencing the values to the key
"user".
> The
> second one looks wrong because it seems to be redefining the key
"user" to
> two different things, username and password.
> 
> When you do User.new(params[:user]), you are passing the hash to the model
> to build a new user object.  This would be the same as User.new(:username
> =>
> "foo", :password => "secret", ...)
> 
> the call to new is also given a hash.
> 
> 
> 
> On 3/3/06, Greg <gmacgregor@gmail.com> wrote:
> >
> >
> > 2 quick questions regarding authentication ...
> >
> > 1) the flash[:notice] on successful login looks completely wrong to
me.
> > How should it be done?
> >
> >   def index
> >     if request.post?
> >       @user = User.new(params[:user])
> >       authentic_user = @user.attempt_login
> >       if authentic_user
> >         session[:user_id] = authentic_user.id
> >         flash[:notice]  > >         ''Login successful!
Welcome '' + authentic_user.first_name + '' '' +
> >         authentic_user.last_name + ''!''
> >         redirect_to(:controller => ''user'')
> >       else
> >         flash[:notice] = ''Invalid username or
password.''
> >       end
> >     end
> >   end
> >
> > 2) can someone explain why the first of these two techniques works
(ie,
> > login is successful) but the second doesn''t:
> >
> > @user = User.new(params[:user])
> > @user = User.new(params[:user => ''username'',
:user => ''password''])
> >
> > ... given this model:
> >
> > class User < ActiveRecord::Base
> >   attr_accessor :password
> >   attr_accessible :username, :password
> >
> >   def before_create
> >     self.hashed_password = User.encrypt_password(self.password)
> >   end
> >
> >   def after_create
> >     @password = nil
> >   end
> >
> >   def self.login(username, password)
> >     hashed_password = encrypt_password(password ||
'''')
> >     find(:first,
> >          :conditions => [''username = ? and hashed_password
=?'',
> >          username, hashed_password])
> >   end
> >
> >   def attempt_login
> >     User.login(self.username, self.password)
> >   end
> >
> >   private
> >   def self.encrypt_password(password)
> >     Digest::SHA1.hexdigest(password)
> >   end
> >
> > end
> >
> > ... and assuming a form with fields
''name=user[username]'' &
> > ''name=user[password]''. Thanks for the help. Kindly
appreciated.
> >
> > Greg
> >
> >
> > --
> > Posted via http://www.ruby-forum.com/.
> > _______________________________________________
> > Rails mailing list
> > Rails@lists.rubyonrails.org
> > http://lists.rubyonrails.org/mailman/listinfo/rails
> >
>

Peter Ertl

2006-Mar-04 08:53 UTC

head link

[Rails] Two quick newbie questions

this is what you want:

user = User.new(:username => "the username", :password =>
"the password")

> --- Urspr?ngliche Nachricht ---
> Von: "Manish Shah" <mnshah@gmail.com>
> An: rails@lists.rubyonrails.org
> Betreff: Re: [Rails] Two quick newbie questions
> Datum: Sat, 4 Mar 2006 00:42:35 -0800
> 
> for the 1st question:
> 
> I''m fairly new to rails too, but i dont think thats how you
concatenate
> strings in ruby.  I think you need "<<" where the
"+" is.
> 
> 
> for the 2nd question:
> 
> params is a hash, and you are referencing the values to the key
"user".
> The
> second one looks wrong because it seems to be redefining the key
"user" to
> two different things, username and password.
> 
> When you do User.new(params[:user]), you are passing the hash to the model
> to build a new user object.  This would be the same as User.new(:username
> =>
> "foo", :password => "secret", ...)
> 
> the call to new is also given a hash.
> 
> 
> 
> On 3/3/06, Greg <gmacgregor@gmail.com> wrote:
> >
> >
> > 2 quick questions regarding authentication ...
> >
> > 1) the flash[:notice] on successful login looks completely wrong to
me.
> > How should it be done?
> >
> >   def index
> >     if request.post?
> >       @user = User.new(params[:user])
> >       authentic_user = @user.attempt_login
> >       if authentic_user
> >         session[:user_id] = authentic_user.id
> >         flash[:notice]  > >         ''Login successful!
Welcome '' + authentic_user.first_name + '' '' +
> >         authentic_user.last_name + ''!''
> >         redirect_to(:controller => ''user'')
> >       else
> >         flash[:notice] = ''Invalid username or
password.''
> >       end
> >     end
> >   end
> >
> > 2) can someone explain why the first of these two techniques works
(ie,
> > login is successful) but the second doesn''t:
> >
> > @user = User.new(params[:user])
> > @user = User.new(params[:user => ''username'',
:user => ''password''])
> >
> > ... given this model:
> >
> > class User < ActiveRecord::Base
> >   attr_accessor :password
> >   attr_accessible :username, :password
> >
> >   def before_create
> >     self.hashed_password = User.encrypt_password(self.password)
> >   end
> >
> >   def after_create
> >     @password = nil
> >   end
> >
> >   def self.login(username, password)
> >     hashed_password = encrypt_password(password ||
'''')
> >     find(:first,
> >          :conditions => [''username = ? and hashed_password
=?'',
> >          username, hashed_password])
> >   end
> >
> >   def attempt_login
> >     User.login(self.username, self.password)
> >   end
> >
> >   private
> >   def self.encrypt_password(password)
> >     Digest::SHA1.hexdigest(password)
> >   end
> >
> > end
> >
> > ... and assuming a form with fields
''name=user[username]'' &
> > ''name=user[password]''. Thanks for the help. Kindly
appreciated.
> >
> > Greg
> >
> >
> > --
> > Posted via http://www.ruby-forum.com/.
> > _______________________________________________
> > Rails mailing list
> > Rails@lists.rubyonrails.org
> > http://lists.rubyonrails.org/mailman/listinfo/rails
> >
>

Peter Ertl

2006-Mar-04 08:54 UTC

head link

[Rails] Two quick newbie questions

try that instead:

flash[:notice]  = ''Login successful! Welcome
#{authentic_user.first_name}
#{authentic_user.last_name}!''

one of the things why I love ruby...

> --- Urspr?ngliche Nachricht ---
> Von: "Peter Ertl" <pertl@gmx.org>
> An: rails@lists.rubyonrails.org
> Betreff: Re: [Rails] Two quick newbie questions
> Datum: Sat, 4 Mar 2006 09:49:52 +0100 (MET)
> 
> irb(main):001:0> "XXX" + "123"
> => "XXX123"
> 
> 
> > --- Urspr?ngliche Nachricht ---
> > Von: "Manish Shah" <mnshah@gmail.com>
> > An: rails@lists.rubyonrails.org
> > Betreff: Re: [Rails] Two quick newbie questions
> > Datum: Sat, 4 Mar 2006 00:42:35 -0800
> > 
> > for the 1st question:
> > 
> > I''m fairly new to rails too, but i dont think thats how you
concatenate
> > strings in ruby.  I think you need "<<" where the
"+" is.
> > 
> > 
> > for the 2nd question:
> > 
> > params is a hash, and you are referencing the values to the key
"user".
> > The
> > second one looks wrong because it seems to be redefining the key
"user"
> to
> > two different things, username and password.
> > 
> > When you do User.new(params[:user]), you are passing the hash to the
> model
> > to build a new user object.  This would be the same as
> User.new(:username
> > =>
> > "foo", :password => "secret", ...)
> > 
> > the call to new is also given a hash.
> > 
> > 
> > 
> > On 3/3/06, Greg <gmacgregor@gmail.com> wrote:
> > >
> > >
> > > 2 quick questions regarding authentication ...
> > >
> > > 1) the flash[:notice] on successful login looks completely wrong
to
> me.
> > > How should it be done?
> > >
> > >   def index
> > >     if request.post?
> > >       @user = User.new(params[:user])
> > >       authentic_user = @user.attempt_login
> > >       if authentic_user
> > >         session[:user_id] = authentic_user.id
> > >         flash[:notice]  > > >         ''Login
successful! Welcome '' + authentic_user.first_name + ''
''
> +
> > >         authentic_user.last_name + ''!''
> > >         redirect_to(:controller => ''user'')
> > >       else
> > >         flash[:notice] = ''Invalid username or
password.''
> > >       end
> > >     end
> > >   end
> > >
> > > 2) can someone explain why the first of these two techniques
works
> (ie,
> > > login is successful) but the second doesn''t:
> > >
> > > @user = User.new(params[:user])
> > > @user = User.new(params[:user => ''username'',
:user => ''password''])
> > >
> > > ... given this model:
> > >
> > > class User < ActiveRecord::Base
> > >   attr_accessor :password
> > >   attr_accessible :username, :password
> > >
> > >   def before_create
> > >     self.hashed_password = User.encrypt_password(self.password)
> > >   end
> > >
> > >   def after_create
> > >     @password = nil
> > >   end
> > >
> > >   def self.login(username, password)
> > >     hashed_password = encrypt_password(password ||
'''')
> > >     find(:first,
> > >          :conditions => [''username = ? and
hashed_password =?'',
> > >          username, hashed_password])
> > >   end
> > >
> > >   def attempt_login
> > >     User.login(self.username, self.password)
> > >   end
> > >
> > >   private
> > >   def self.encrypt_password(password)
> > >     Digest::SHA1.hexdigest(password)
> > >   end
> > >
> > > end
> > >
> > > ... and assuming a form with fields
''name=user[username]'' &
> > > ''name=user[password]''. Thanks for the help.
Kindly appreciated.
> > >
> > > Greg
> > >
> > >
> > > --
> > > Posted via http://www.ruby-forum.com/.
> > > _______________________________________________
> > > Rails mailing list
> > > Rails@lists.rubyonrails.org
> > > http://lists.rubyonrails.org/mailman/listinfo/rails
> > >
> > 
> _______________________________________________
> Rails mailing list
> Rails@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails
>

Maybe Matching Threads

Search for more apparently analagous threads

Rails - Mar 2006 - Two quick newbie questions

[Rails] Two quick newbie questions

[Rails] Two quick newbie questions

[Rails] Two quick newbie questions

[Rails] Two quick newbie questions

[Rails] Two quick newbie questions

Maybe Matching Threads