Hello, I submitted a patch <http://dev.rubyonrails.org/ticket/3287> ( http://dev.rubyonrails.org/ticket/3287) a couple of days ago. The patch adds some methods into and changes the existing methods in the CaptureHelper module. It should not, as I can see, affect any existing Rails implementations. I added the relevant unit tests and all but one of the tests pass. The test that fails failed since I started using Edge Rails (before I made changes) and seems unrelated. <http://dev.rubyonrails.org/ticket/3287> This is my first patch that affects any code in Rails. How long does it typically take to get feedback on a patch of this nature? Are things backlogged right now with the release of 1.0.0? -- Thank you, Brian Takita http://weblog.freeopinion.org _______________________________________________ Rails mailing list Rails-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org http://lists.rubyonrails.org/mailman/listinfo/rails
Hi ! 2005/12/21, Brian Takita <brian.takita@gmail.com>:> This is my first patch that affects any code in Rails. How long does it > typically take to get feedback on a patch of this nature? > Are things backlogged right now with the release of 1.0.0?It's always taken a long time for any of my patches to be accepted. Your best bet is to send a message to rails-core, and discuss the matter there. Ask for a public review. Bye ! -- François Beausoleil http://blog.teksol.info/ _______________________________________________ Rails mailing list Rails-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org http://lists.rubyonrails.org/mailman/listinfo/rails
> > This is my first patch that affects any code in Rails. How long does it > > typically take to get feedback on a patch of this nature? > > Are things backlogged right now with the release of 1.0.0?We definitely have a significant backlog on processing new tickets for Rails. The 1.0 crunch was a sprint and most of the core team is taking some restitution from that to work on their real job for a bit ;). So to you and everyone else with stuff in the queue, we appreciate your patience. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
I made a brief post on this and how I am using switchtower to deploy uncommitted patches to production. http://weblog.freeopinion.org/articles/2005/12/22/backlog-for-new-rails-patches On 12/21/05, David Heinemeier Hansson <david.heinemeier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> > > > This is my first patch that affects any code in Rails. How long does > it > > > typically take to get feedback on a patch of this nature? > > > Are things backlogged right now with the release of 1.0.0? > > We definitely have a significant backlog on processing new tickets for > Rails. The 1.0 crunch was a sprint and most of the core team is taking > some restitution from that to work on their real job for a bit ;). So > to you and everyone else with stuff in the queue, we appreciate your > patience. > -- > David Heinemeier Hansson > http://www.loudthinking.com -- Broadcasting Brain > http://www.basecamphq.com -- Online project management > http://www.backpackit.com -- Personal information manager > http://www.rubyonrails.com -- Web-application framework > _______________________________________________ > Rails mailing list > Rails-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org > http://lists.rubyonrails.org/mailman/listinfo/rails >-- Brian Takita http://weblog.freeopinion.org _______________________________________________ Rails mailing list Rails-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org http://lists.rubyonrails.org/mailman/listinfo/rails