Hello, 1) I'm planning on adding lots of measurements to the driver liebert-esp2 + correct support for 3-phase systems. Should I make a large patch based on the last svn head or send you the whole file? Multiple patches per change are probably not practical in this case. 2) in http://www.networkupstools.org/doc/2.2.0/new-names.html there is no crest factor variable. Crest factor is very important for large installations. Should I add a new variable named crestfactor ? (Crest factor shows the ratio between the peak and the RMS) If you have a liebert ups, please send me the output from the program I last sent you. Thanks, -Spiros -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20100413/010ebdd0/attachment.htm>
Hi Guys, I tested Spiros code and attached the my output, but someone rejected my mail from Nut moderators. Why? You didn't give the reason. Pls accept it 2010/4/13 Spiros Ioannou <sivann at gmail.com>> Hello, > 1) I'm planning on adding lots of measurements to the driver liebert-esp2 + > correct support for 3-phase systems. Should I make a large patch based on > the last svn head or send you the whole file? Multiple patches per change > are probably not practical in this case. > > 2) in http://www.networkupstools.org/doc/2.2.0/new-names.html there is no > crest factor variable. Crest factor is very important for large > installations. Should I add a new variable named crestfactor ? (Crest factor > shows the ratio between the peak and the RMS) > > If you have a liebert ups, please send me the output from the program I > last sent you. > > Thanks, > > -Spiros > > _______________________________________________ > Nut-upsdev mailing list > Nut-upsdev at lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev >-- Best Regards, Robert -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20100413/baa0ce29/attachment.htm>
Citeren Spiros Ioannou <sivann op gmail.com>:> 1) I'm planning on adding lots of measurements to the driver liebert-esp2 + > correct support for 3-phase systems. Should I make a large patch based on > the last svn head or send you the whole file? Multiple patches per change > are probably not practical in this case.If possible, separate patches that modify existing code/behavior from patches that add new functionality/variables. The latter are less likely to break existing installations.> 2) in http://www.networkupstools.org/doc/2.2.0/new-names.html there is no > crest factor variable. Crest factor is very important for large > installations. Should I add a new variable named crestfactor ? (Crest factor > shows the ratio between the peak and the RMS)I added 'output.crestfactor' and 'outlet.n.crestfactor' to the list of supported variables. Best regards, Arjen -- Please keep list traffic on the list
I attached it again. 2010/4/14 Spiros Ioannou <sivann at gmail.com>> Hi Robert, > I think there is a size limit on the list. Try zipping the attachment. > Also, you can mail directly to me. > Thanks! > -S > > > On Tue, Apr 13, 2010 at 11:25 PM, Robert Jobbagy <jobbagy.robert at gmail.com > > wrote: > >> Hi Guys, >> >> I tested Spiros code and attached the my output, but someone rejected my >> mail from Nut moderators. >> Why? You didn't give the reason. >> Pls accept it >> >> >> 2010/4/13 Spiros Ioannou <sivann at gmail.com> >> >>> Hello, >>> 1) I'm planning on adding lots of measurements to the driver liebert-esp2 >>> + correct support for 3-phase systems. Should I make a large patch based on >>> the last svn head or send you the whole file? Multiple patches per change >>> are probably not practical in this case. >>> >>> 2) in http://www.networkupstools.org/doc/2.2.0/new-names.html there is >>> no crest factor variable. Crest factor is very important for large >>> installations. Should I add a new variable named crestfactor ? (Crest factor >>> shows the ratio between the peak and the RMS) >>> >>> If you have a liebert ups, please send me the output from the program I >>> last sent you. >>> >>> Thanks, >>> >>> -Spiros >>> >>> _______________________________________________ >>> Nut-upsdev mailing list >>> Nut-upsdev at lists.alioth.debian.org >>> http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev >>> >> >> >> >> -- >> Best Regards, >> >> Robert >> > >-- Best Regards, Robert -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20100414/2952f733/attachment.htm> -------------- next part -------------- A non-text attachment was scrubbed... Name: liebertgxt2_1000RT230_log.tar.gz Type: application/x-gzip Size: 3462 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20100414/2952f733/attachment.bin>