Nut upsdev - Apr 2010 - Liebert GXT2 NUT driver - patch, multiple fixes

based on r2432, i took this with "svn diff --revision HEAD
liebert-esp2.c"

fixes:
1) new way to initialize model, firmware etc. variables, the strok way
failed because some vars had spaces. (e.g. model "Liebert NX")
2) new multipliers for: frequency, nominal power. I get correct readings
now, before I had 500 Hz, and 200VA and now it's ok for me. Test with your
models.
3) added battery temperature
4) removed battery.charge. BATTERY_CAPACITY != charge, BATTERY_CAPACITY
means how much the battery has lost its original energy capacity from aging.

-S

sample outout:
ambient.temperature: 25.0
battery.current: 0.00
battery.runtime: 11940
battery.temperature: 20.1
battery.voltage: 540.5
battery.voltage.nominal: 0.0
device.mfr: Liebert
device.model: Liebert NX
device.type: ups
driver.name: liebert-esp2
driver.parameter.baudrate: 9600
driver.parameter.pollinterval: 2
driver.parameter.port: /dev/ttyS0
driver.version: 2.4.3-2432M
driver.version.internal: 0.02
input.bypass.voltage: 238.7
input.frequency: 50.0
input.frequency.nominal: 50.0
input.voltage: 238.6
output.current: 4.1
output.frequency: 50.0
output.voltage: 230.8
ups.firmware: I170R150M260
ups.load: 0
ups.mfr: Liebert
ups.model: Liebert NX
ups.power: 0
ups.power.nominal: 20000
ups.realpower: 0
ups.status: OL
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20100410/ea567687/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: liebert-esp2.diff
Type: application/octet-stream
Size: 3636 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20100410/ea567687/attachment.obj>

Citeren Spiros Ioannou <sivann op gmail.com>:
> 1) new way to initialize model, firmware etc. variables, the strok way
> failed because some vars had spaces. (e.g. model "Liebert NX")
Thanks for this patch. I adopted this idea and committed a slightly  
modified version to the development version.
> 2) new multipliers for: frequency, nominal power. I get correct readings
> now, before I had 500 Hz, and 200VA and now it's ok for me. Test with
your
> models.
I would like to get some upsc output (latest development version, no  
patches) from Liebert NX and GXT2 owners before committing this. I'm  
not quite sure we got everything right now. Check *all* returned  
values from the upsc output if they are reasonable. If not, provide  
the debug output (-DDD) as well to see the raw output from the UPS.
> 3) added battery temperature
Committed, thanks.
> 4) removed battery.charge. BATTERY_CAPACITY != charge, BATTERY_CAPACITY
> means how much the battery has lost its original energy capacity from
aging.
Same as the above.

Note that we prefer to break up patches to contain only a single  
modification. So it would have been better to break up this change in  
four patches, each changing one of the above.

I also noticed you changed the 'ups.temperature' to  
'ambient.temperature'. Note that this change requires an external  
sensor to be attached to the UPS, otherwise we consider this to be the  
device (UPS) temperature.

Best regards, Arjen
-- 
Please keep list traffic on the list

Hello, I have no feedback on this and I'm affraid it was lost since I
sent it as a reply to a thread.
This is a big patch that I'm hoping will fix most of the issues.
Mainly 3-phase support + easy multiplier customization per model on
the driver.

It is described here:

http://lists.alioth.debian.org/pipermail/nut-upsdev/2010-April/004802.html

Best Regards,
-Spiros