Nouveau - Sep 2018 - [Bug 108032] New: nv50_ir_lowering_gm107.cpp:326: undefined reference to `nv50_ir::NVC0LoweringPass::loadMsAdjInfo32(nv50_ir::TexInstruction::Target, unsigned int, int, nv50_ir::Value*, bool)'

https://bugs.freedesktop.org/show_bug.cgi?id=108032

            Bug ID: 108032
           Summary: nv50_ir_lowering_gm107.cpp:326: undefined reference to
                    `nv50_ir::NVC0LoweringPass::loadMsAdjInfo32(nv50_ir::T
                    exInstruction::Target, unsigned int, int,
                    nv50_ir::Value*, bool)'
           Product: Mesa
           Version: git
          Hardware: All
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: pedretti.fabio at gmail.com
        QA Contact: nouveau at lists.freedesktop.org
                CC: pendingchaos02+fdobugzilla at gmail.com

Since latest commits mesa fails to build with:
./.libs/libnouveau.a(nv50_ir_lowering_gm107.o): In function
`nv50_ir::GM107LoweringPass::handleSUQ(nv50_ir::TexInstruction*)':
/<<PKGBUILDDIR>>/build/src/gallium/drivers/nouveau/../../../../../src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_gm107.cpp:326:
undefined reference to
`nv50_ir::NVC0LoweringPass::loadMsAdjInfo32(nv50_ir::TexInstruction::Target,
unsigned int, int, nv50_ir::Value*, bool)'
/<<PKGBUILDDIR>>/build/src/gallium/drivers/nouveau/../../../../../src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_gm107.cpp:322:
undefined reference to
`nv50_ir::NVC0LoweringPass::loadMsAdjInfo32(nv50_ir::TexInstruction::Target,
unsigned int, int, nv50_ir::Value*, bool)'
collect2: error: ld returned 1 exit status
Makefile:1178: recipe for target 'nouveau_compiler' failed

Full build log with configure options here:
https://launchpadlibrarian.net/389864818/buildlog_ubuntu-xenial-i386.mesa_18.3~git1809230730.b473fc~oibaf~x_BUILDING.txt.gz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180923/5554ec18/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=108032

--- Comment #1 from Rhys Perry <pendingchaos02+fdobugzilla at gmail.com>
---
This builds fine for me, so I guess it's some compiler quirk.

Does removing the "inline" on line 1735 in nv50_ir_lowering_nvc0.cpp
(at the
implementation of loadMsAdjInfo32()) fix the problem?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180923/26062667/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=108032

--- Comment #2 from Rhys Perry <pendingchaos02+fdobugzilla at gmail.com>
---
Seems that although I can't reproduce it with 64-bit targeted Meson, I can
with
with 32-bit targeted autotools.

Removing the inline does fix the error and I've posted a patch doing that:
https://lists.freedesktop.org/archives/mesa-dev/2018-September/205821.html

It or something similar should be pushed soon.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180923/47394f07/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=108032

Rhys Perry <pendingchaos02+fdobugzilla at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Rhys Perry <pendingchaos02+fdobugzilla at gmail.com>
---
Fixed by:

commit 6ca1402c117856b55d044be1e82224db30ed1b02
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Sun Sep 23 17:57:08 2018 +0100

    nv50/ir: fix link-time build failure

    Seems this fixes linking problems that occur in some situations.

    Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
    Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180923/750f0936/attachment.html>