Ilia Mirkin
2014-Jan-27 20:51 UTC
[Nouveau] [PATCH] nv30: don't overwrite blend color setting for r32/r16 float formats
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
---
Untested. Happened to see this when I was reading this file (don't ask). I
can't imagine the current situation to be the intended one, based on this
code...
src/gallium/drivers/nouveau/nv30/nv30_state_validate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c
b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c
index f227559..b5584c8 100644
--- a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c
+++ b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c
@@ -190,7 +190,7 @@ nv30_validate_blend_colour(struct nv30_context *nv30)
BEGIN_NV04(push, SUBC_3D(0x037c), 1);
PUSH_DATA (push, (util_float_to_half(rgba[2]) << 0) |
(util_float_to_half(rgba[3]) << 16));
- break;
+ return;
default:
break;
}
--
1.8.3.2
Possibly Parallel Threads
- [PATCH 1/2] nv30: avoid doing extra work on clear and hitting unexpected states
- [Mesa-dev] [PATCH 2/2] nv30: fix clip plane uploads and enable changes
- [Mesa-dev] [PATCH 2/2] nv30: fix clip plane uploads and enable changes
- [Mesa-dev] [PATCH 2/2] nv30: fix clip plane uploads and enable changes
- [PATCH 1/2] nv30/draw: rework some of the output vertex buffer logic
