search for: nv30_state_validate

...earing. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/gallium/drivers/nouveau/nv30/nv30_clear.c | 2 +- src/gallium/drivers/nouveau/nv30/nv30_context.h | 2 +- src/gallium/drivers/nouveau/nv30/nv30_draw.c | 4 ++-- src/gallium/drivers/nouveau/nv30/nv30_state_validate.c | 10 ++++++---- src/gallium/drivers/nouveau/nv30/nv30_vbo.c | 2 +- 5 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv30/nv30_clear.c b/src/gallium/drivers/nouveau/nv30/nv30_clear.c index 1ab8929..83fd1fa 100644 --- a/src/gallium/drivers/no...

...clip depends on the rasterizer state. Also we should > upload all the new clip planes on change since next time the plane data > won't have changed, but the enables might. > > Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> > --- > src/gallium/drivers/nouveau/nv30/nv30_state_validate.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c > index 86ac4f7..a954dcc 100644 > --- a/src/gallium/drivers/nouveau/nv30/nv30_s...

...ould >>> upload all the new clip planes on change since next time the plane data >>> won't have changed, but the enables might. >>> >>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> >>> --- >>> src/gallium/drivers/nouveau/nv30/nv30_state_validate.c | 16 +++++++--------- >>> 1 file changed, 7 insertions(+), 9 deletions(-) >>> >>> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >>> index 86ac4f7..a954dcc 100644 >>> --- a...

...p planes on change since next time the plane data >>>>> won't have changed, but the enables might. >>>>> >>>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> >>>>> --- >>>>> src/gallium/drivers/nouveau/nv30/nv30_state_validate.c | 16 >>>>> +++++++--------- >>>>> 1 file changed, 7 insertions(+), 9 deletions(-) >>>>> >>>>> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >>>>> b/src/gallium/drivers/nouveau/nv30/nv30_state_valida...

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- Untested. Happened to see this when I was reading this file (don't ask). I can't imagine the current situation to be the intended one, based on this code... src/gallium/drivers/nouveau/nv30/nv30_state_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c index f227559..b5584c8 100644 --- a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c +++ b/src/gallium/drivers/...

For all these patches I'd say: testers are welcome. The first three patches seem good enough to push as we speak IMHO (so if you agree, go ahead!), whereas for the fourth I don't know if this is the desired way to fix. The result of these four patches is that NV34 gives a nearly-correct desktop experience, where only some fading animations appear broken. It's quite useable now! [1/4]:

...PUSH_RESRC(push, NV30_3D(VTXBUF(i)), BUFCTX_VTXTMP, nv04_resource(r->buffer), r->offset + r->vtxptr[i], - NOUVEAU_BO_LOW | NOUVEAU_BO_RD, 0, 0); + NOUVEAU_BO_LOW | NOUVEAU_BO_RD, 0, NV30_3D_VTXBUF_DMA1); } if (!nv30_state_validate(nv30, ~0, FALSE)) return; + if (nv30->base.vbo_dirty) { + BEGIN_NV04(push, NV30_3D(VTX_CACHE_INVALIDATE_1710), 1); + PUSH_DATA (push, 0); + nv30->base.vbo_dirty = FALSE; + } + BEGIN_NV04(push, NV30_3D(VERTEX_BEGIN_END), 1); PUSH_DATA (push, r->prim); @...

Hi Ilia, you were straight to the point for me in: "src/mesa/vbo will upload it to a vbo. The driver then points the hardware at the vbo and tells it to read from there." But where is it the function that implements this? Is it in nv30_draw_vbo(...)? Please, give me a function name or at least a file name? 2016-04-19 10:04 GMT-04:00 Ilia Mirkin <imirkin at alum.mit.edu>: >

...alling nv30_clear(...) which calls BEGIN_NV04(push, NV30_3D(CLEAR_DEPTH_VALUE), 3); and the valgrind--mmt output is 0xcfd8c in line 281 of the valgrind-mmt's output file. As I can see there is 215 lines (from 66 to 280) of valgrind--mmt that I do not know from where is it coming. I could dig in nv30_state_validate(...) but at this moment I think nv30->dirty is 0 so validate->func(nv30) is not called. Help, please.*/ /* This I guess is mesa stuff... */ glMatrixMode(GL_PROJECTION); glLoadIdentity(); glOrtho(0, 300, 0, 300, -1, 1); glMatrixMode(GL_MODELVIEW); /*Here another question. Do...

...ipe = 0x805cc70 transfer = 0x82fece0 map = 0x805cc70 #6 nv30_fragprog_validate (nv30=0x805cc70) at nv30_fragprog.c:96 push = 0x8078938 eng3d = 0x808d2d8 fp = 0x829f968 upload = <optimized out> i = <optimized out> #7 0xb66e3e65 in nv30_state_validate (nv30=nv30 at entry=0x805cc70, hwtnl=hwtnl at entry=1 '\001') at nv30_state_validate.c:487 screen = 0x8078800 push = 0x8078938 bctx = 0x805d340 bref = <optimized out> validate = 0xb76a9d78 <hwtnl_validate_list+88> #8 0xb66c629e in nv30_dr...

https://bugs.freedesktop.org/show_bug.cgi?id=102349 Bug ID: 102349 Summary: nv4x crashing with plasmashell - gdb log included Product: xorg Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: blocker Priority: medium Component: Driver/nouveau

...that implements this? Is it in > nv30_draw_vbo(...)? Please, give me a function name or > at least a file name? Before draw_vbo is called, the vbo will have been set up via pipe->bind_vertex_elements_state and pipe->set_vertex_buffers. The draw call will then validate those, by calling nv30_state_validate (or something along those lines) which will look at all the dirtied state and write that out to hw. There are also funny interactions with translate... for formats that aren't directly supported. -ilia

...alls > BEGIN_NV04(push, NV30_3D(CLEAR_DEPTH_VALUE), 3); and the valgrind--mmt > output is > 0xcfd8c in line 281 of the valgrind-mmt's output file. > As I can see there is 215 lines (from 66 to 280) of valgrind--mmt that I do > not know > from where is it coming. I could dig in nv30_state_validate(...) but at this > moment I > think nv30->dirty is 0 so validate->func(nv30) is not called. Help, > please.*/ dirty definitely shouldn't be 0... it has to bind a framebuffer at least. > > > /* This I guess is mesa stuff... */ > glMatrixMode(GL_PROJECTION); >...

...ntext.h | 2 + src/gallium/drivers/nouveau/nv30/nv30_draw.c | 4 +- src/gallium/drivers/nouveau/nv30/nv30_query.c | 6 +- src/gallium/drivers/nouveau/nv30/nv30_screen.c | 160 ++++--------- src/gallium/drivers/nouveau/nv30/nv30_screen.h | 4 +- .../drivers/nouveau/nv30/nv30_state_validate.c | 9 +- src/gallium/drivers/nouveau/nv50/nv50_context.c | 128 ++++++++--- src/gallium/drivers/nouveau/nv50/nv50_context.h | 33 ++- src/gallium/drivers/nouveau/nv50/nv50_program.c | 2 +- src/gallium/drivers/nouveau/nv50/nv50_query.c | 2 +- src/gallium/drivers/nouveau/n...

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- src/gallium/drivers/nouveau/nouveau_fence.c | 76 ++++++++++++------------- src/gallium/drivers/nouveau/nouveau_fence.h | 22 +++++-- src/gallium/drivers/nouveau/nouveau_screen.c | 9 +++ src/gallium/drivers/nouveau/nouveau_screen.h | 14 ++--- src/gallium/drivers/nouveau/nv30/nv30_context.c | 4 +-

...src/gallium/drivers/nouveau/nv30/nv30_draw.c | 4 +- > src/gallium/drivers/nouveau/nv30/nv30_query.c | 6 +- > src/gallium/drivers/nouveau/nv30/nv30_screen.c | 160 ++++--------- > src/gallium/drivers/nouveau/nv30/nv30_screen.h | 4 +- > .../drivers/nouveau/nv30/nv30_state_validate.c | 9 +- > src/gallium/drivers/nouveau/nv50/nv50_context.c | 128 ++++++++--- > src/gallium/drivers/nouveau/nv50/nv50_context.h | 33 ++- > src/gallium/drivers/nouveau/nv50/nv50_program.c | 2 +- > src/gallium/drivers/nouveau/nv50/nv50_query.c | 2 +- > src/...

...v30_context.h b/src/gallium/drivers/nv30/nv30_context.h index 8d49366..6f44b1c 100644 --- a/src/gallium/drivers/nv30/nv30_context.h +++ b/src/gallium/drivers/nv30/nv30_context.h @@ -184,6 +184,7 @@ extern void nv30_fragtex_bind(struct nv30_context *); /* nv30_state.c and friends */ extern boolean nv30_state_validate(struct nv30_context *nv30); extern void nv30_state_emit(struct nv30_context *nv30); +extern void nv30_state_flush_notify(struct nouveau_channel *chan); extern struct nv30_state_entry nv30_state_rasterizer; extern struct nv30_state_entry nv30_state_scissor; extern struct nv30_state_entry nv30_st...

https://bugs.freedesktop.org/show_bug.cgi?id=73358 Priority: medium Bug ID: 73358 Assignee: nouveau at lists.freedesktop.org Summary: [nv34] adobe flash + firefox -> DATA_ERROR QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: All Reporter: ronald645 at gmail.com

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- src/gallium/drivers/nouveau/nouveau_fence.c | 76 ++++++++++++------------- src/gallium/drivers/nouveau/nouveau_fence.h | 22 +++++-- src/gallium/drivers/nouveau/nouveau_screen.c | 9 +++ src/gallium/drivers/nouveau/nouveau_screen.h | 14 ++--- src/gallium/drivers/nouveau/nv30/nv30_context.c | 4

...v30_context.h b/src/gallium/drivers/nv30/nv30_context.h index 8d49366..6f44b1c 100644 --- a/src/gallium/drivers/nv30/nv30_context.h +++ b/src/gallium/drivers/nv30/nv30_context.h @@ -184,6 +184,7 @@ extern void nv30_fragtex_bind(struct nv30_context *); /* nv30_state.c and friends */ extern boolean nv30_state_validate(struct nv30_context *nv30); extern void nv30_state_emit(struct nv30_context *nv30); +extern void nv30_state_flush_notify(struct nouveau_channel *chan); extern struct nv30_state_entry nv30_state_rasterizer; extern struct nv30_state_entry nv30_state_scissor; extern struct nv30_state_entry nv30_st...