llvm dev - Jan 2018 - [Release-testers] [6.0.0 Release] Release Candidate 1 tagged

On Thu, Jan 18, 2018 at 7:27 PM, Dimitry Andric <dimitry at andric.com>
wrote:
> On 18 Jan 2018, at 15:03, Jonas Hahnfeld <hahnjo at hahnjo.de> wrote:
>>
>> Am 2018-01-18 14:55, schrieb Dimitry Andric via llvm-dev:
>>> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
>>> <release-testers at lists.llvm.org> wrote:
>>>> Start your engines; 6.0.0-rc1 was just tagged.
>>>> I know there are still open blockers and it's early in the
process in
>>>> a way, but I'd like to find out where we are. Please run
the test
>>>> script, let me know the results, and upload binaries.
>>> At the moment I can't compile openmp, since it errors out on
libomptarget:
>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10:
>>> error: use of undeclared identifier 'malloc'
>>>    rc = malloc(size);
>>>         ^
>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5:
>>> error: use of undeclared identifier 'free'
>>>    free(device_ptr);
>>>    ^
>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20:
>>> error: use of undeclared identifier 'malloc'
>>>    void *buffer = malloc(length);
>>>                   ^
>>> I'm trying a local fix here, namely including <cstdlib>
at the top of the file.
>>
>> Argh, I have missed that header. Adding <cstdlib> sounds like the
right solution, can you submit a patch or directly commit to SVN if it works for
you?
>
> I added <cstdlib> to api.cpp, interface.cpp and rtl.cpp, in r322869. 
Hans, could you please merge it to release_60, or shall I do it?
Go ahead if you're set up, otherwise let me know and I'll do it.

On 19 Jan 2018, at 17:11, Hans Wennborg <hans at chromium.org>
wrote:
> 
> On Thu, Jan 18, 2018 at 7:27 PM, Dimitry Andric <dimitry at
andric.com> wrote:
>> On 18 Jan 2018, at 15:03, Jonas Hahnfeld <hahnjo at hahnjo.de>
wrote:
>>> 
>>> Am 2018-01-18 14:55, schrieb Dimitry Andric via llvm-dev:
>>>> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
>>>> <release-testers at lists.llvm.org> wrote:
>>>>> Start your engines; 6.0.0-rc1 was just tagged.
>>>>> I know there are still open blockers and it's early in
the process in
>>>>> a way, but I'd like to find out where we are. Please
run the test
>>>>> script, let me know the results, and upload binaries.
>>>> At the moment I can't compile openmp, since it errors out
on libomptarget:
>>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10:
>>>> error: use of undeclared identifier 'malloc'
>>>>   rc = malloc(size);
>>>>        ^
>>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5:
>>>> error: use of undeclared identifier 'free'
>>>>   free(device_ptr);
>>>>   ^
>>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20:
>>>> error: use of undeclared identifier 'malloc'
>>>>   void *buffer = malloc(length);
>>>>                  ^
>>>> I'm trying a local fix here, namely including
<cstdlib> at the top of the file.
>>> 
>>> Argh, I have missed that header. Adding <cstdlib> sounds like
the right solution, can you submit a patch or directly commit to SVN if it works
for you?
>> 
>> I added <cstdlib> to api.cpp, interface.cpp and rtl.cpp, in
r322869.  Hans, could you please merge it to release_60, or shall I do it?
> 
> Go ahead if you're set up, otherwise let me know and I'll do it.
Done in r323037.  I have also taken the liberty of merging r322875 and r322879,
in which I added a '-no-libcxxabi' option to the test-release.sh script.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180120/a9a5b8ab/attachment.sig>

Thanks!

On Sat, Jan 20, 2018 at 1:32 PM, Dimitry Andric <dimitry at andric.com>
wrote:
> On 19 Jan 2018, at 17:11, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Thu, Jan 18, 2018 at 7:27 PM, Dimitry Andric <dimitry at
andric.com> wrote:
>>> On 18 Jan 2018, at 15:03, Jonas Hahnfeld <hahnjo at
hahnjo.de> wrote:
>>>>
>>>> Am 2018-01-18 14:55, schrieb Dimitry Andric via llvm-dev:
>>>>> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
>>>>> <release-testers at lists.llvm.org> wrote:
>>>>>> Start your engines; 6.0.0-rc1 was just tagged.
>>>>>> I know there are still open blockers and it's early
in the process in
>>>>>> a way, but I'd like to find out where we are.
Please run the test
>>>>>> script, let me know the results, and upload binaries.
>>>>> At the moment I can't compile openmp, since it errors
out on libomptarget:
>>>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10:
>>>>> error: use of undeclared identifier 'malloc'
>>>>>   rc = malloc(size);
>>>>>        ^
>>>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5:
>>>>> error: use of undeclared identifier 'free'
>>>>>   free(device_ptr);
>>>>>   ^
>>>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20:
>>>>> error: use of undeclared identifier 'malloc'
>>>>>   void *buffer = malloc(length);
>>>>>                  ^
>>>>> I'm trying a local fix here, namely including
<cstdlib> at the top of the file.
>>>>
>>>> Argh, I have missed that header. Adding <cstdlib> sounds
like the right solution, can you submit a patch or directly commit to SVN if it
works for you?
>>>
>>> I added <cstdlib> to api.cpp, interface.cpp and rtl.cpp, in
r322869.  Hans, could you please merge it to release_60, or shall I do it?
>>
>> Go ahead if you're set up, otherwise let me know and I'll do
it.
>
> Done in r323037.  I have also taken the liberty of merging r322875 and
r322879, in which I added a '-no-libcxxabi' option to the
test-release.sh script.
>
> -Dimitry
>

On 20 Jan 2018, at 13:32, Dimitry Andric via Release-testers <release-testers
at lists.llvm.org> wrote:
> 
> On 19 Jan 2018, at 17:11, Hans Wennborg <hans at chromium.org> wrote:
>> 
>> On Thu, Jan 18, 2018 at 7:27 PM, Dimitry Andric <dimitry at
andric.com> wrote:
>>> On 18 Jan 2018, at 15:03, Jonas Hahnfeld <hahnjo at
hahnjo.de> wrote:
>>>> 
>>>> Am 2018-01-18 14:55, schrieb Dimitry Andric via llvm-dev:
>>>>> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
>>>>> <release-testers at lists.llvm.org> wrote:
>>>>>> Start your engines; 6.0.0-rc1 was just tagged.
>>>>>> I know there are still open blockers and it's early
in the process in
>>>>>> a way, but I'd like to find out where we are.
Please run the test
>>>>>> script, let me know the results, and upload binaries.
...

So, I finally managed to produce some tarballs, and uploaded them:

SHA256 (clang+llvm-6.0.0-rc1-amd64-unknown-freebsd10.tar.xz) =
d93427fd2b8f5aa0d5278f1bd3020add07b8316ff8a512a203bf3c41639d7baf
SHA256 (clang+llvm-6.0.0-rc1-i386-unknown-freebsd10.tar.xz) =
9f283235fb10242b9f79527c0d895260e6efa1c1bb761c57396490c7ccd5f5f0

This was an interesting round of testing, since I attempted to build the
'libs' part for the first time, and things like libcxx, polly etc are
also included.  I had to apply several patches, one of which was to be able to
disable libc++abi, which we can't link against yet on FreeBSD.

During the build of the test-suite, I encountered several instances of link jobs
failing due to the addition of -ldl, which does not exist on FreeBSD.  It is
really a Linuxism, for which I will commit a few fixes.  In addition, some
test-suite programs fail to link on FreeBSD 10.x, since it does not yet have
__cpu_model in the base system's copy of libcompiler-rt.  I solved that with
a local hack.

On amd64-freebsd10 there were 895 test failures:

********************
Testing Time: 9904.87s
********************
[...]
  Expected Passes    : 44958
  Expected Failures  : 185
  Unsupported Tests  : 2938
  Unexpected Failures: 895

On i386-freebsd10 there were 1773 test failures:

********************
Testing Time: 23871.89s
********************
[...]
  Expected Passes    : 42648
  Expected Failures  : 194
  Unsupported Tests  : 1953
  Unexpected Failures: 1773

Of these, a great many were in libc++, mostly due to
-Wtautological-type-limit-compare errors, and "exception_ptr not yet
implemented" errors.  Also all the dynamic address sanitizer tests failed
due to -lpthread not being passed to the linker, but it is a problem I have not
been able to solve.

If anybody is interested in the full error reports, I can upload them somewhere;
just let me know.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180123/b91d3c9f/attachment.sig>