llvm dev - Jan 2018 - [Release-testers] [6.0.0 Release] Release Candidate 1 tagged

Am 2018-01-18 14:55, schrieb Dimitry Andric via
llvm-dev:
> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
> <release-testers at lists.llvm.org> wrote:
>> Start your engines; 6.0.0-rc1 was just tagged.
>> 
>> I know there are still open blockers and it's early in the process
in
>> a way, but I'd like to find out where we are. Please run the test
>> script, let me know the results, and upload binaries.
> 
> At the moment I can't compile openmp, since it errors out on 
> libomptarget:
> 
>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10:
> error: use of undeclared identifier 'malloc'
>     rc = malloc(size);
>          ^
>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5:
> error: use of undeclared identifier 'free'
>     free(device_ptr);
>     ^
>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20:
> error: use of undeclared identifier 'malloc'
>     void *buffer = malloc(length);
>                    ^
> 
> I'm trying a local fix here, namely including <cstdlib> at the
top of
> the file.
Argh, I have missed that header. Adding <cstdlib> sounds like the right 
solution, can you submit a patch or directly commit to SVN if it works 
for you?

If anyone else has problems building libomptarget in Debug: <string> was 
missing in rtl.{cpp,h} which has been merged this morning after rc1 was 
tagged.

Regards,
Jonas

On 18 Jan 2018, at 15:03, Jonas Hahnfeld <hahnjo at hahnjo.de>
wrote:
> 
> Am 2018-01-18 14:55, schrieb Dimitry Andric via llvm-dev:
>> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
>> <release-testers at lists.llvm.org> wrote:
>>> Start your engines; 6.0.0-rc1 was just tagged.
>>> I know there are still open blockers and it's early in the
process in
>>> a way, but I'd like to find out where we are. Please run the
test
>>> script, let me know the results, and upload binaries.
>> At the moment I can't compile openmp, since it errors out on
libomptarget:
>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10:
>> error: use of undeclared identifier 'malloc'
>>    rc = malloc(size);
>>         ^
>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5:
>> error: use of undeclared identifier 'free'
>>    free(device_ptr);
>>    ^
>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20:
>> error: use of undeclared identifier 'malloc'
>>    void *buffer = malloc(length);
>>                   ^
>> I'm trying a local fix here, namely including <cstdlib> at
the top of the file.
> 
> Argh, I have missed that header. Adding <cstdlib> sounds like the
right solution, can you submit a patch or directly commit to SVN if it works for
you?
I added <cstdlib> to api.cpp, interface.cpp and rtl.cpp, in r322869. 
Hans, could you please merge it to release_60, or shall I do it?

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180118/b401e704/attachment.sig>

On Thu, Jan 18, 2018 at 7:27 PM, Dimitry Andric <dimitry at andric.com>
wrote:
> On 18 Jan 2018, at 15:03, Jonas Hahnfeld <hahnjo at hahnjo.de> wrote:
>>
>> Am 2018-01-18 14:55, schrieb Dimitry Andric via llvm-dev:
>>> On 17 Jan 2018, at 18:53, Hans Wennborg via Release-testers
>>> <release-testers at lists.llvm.org> wrote:
>>>> Start your engines; 6.0.0-rc1 was just tagged.
>>>> I know there are still open blockers and it's early in the
process in
>>>> a way, but I'd like to find out where we are. Please run
the test
>>>> script, let me know the results, and upload binaries.
>>> At the moment I can't compile openmp, since it errors out on
libomptarget:
>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:50:10:
>>> error: use of undeclared identifier 'malloc'
>>>    rc = malloc(size);
>>>         ^
>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:76:5:
>>> error: use of undeclared identifier 'free'
>>>    free(device_ptr);
>>>    ^
>>>
/home/dim/llvm-6.0.0/rc1/llvm.src/projects/openmp/libomptarget/src/api.cpp:163:20:
>>> error: use of undeclared identifier 'malloc'
>>>    void *buffer = malloc(length);
>>>                   ^
>>> I'm trying a local fix here, namely including <cstdlib>
at the top of the file.
>>
>> Argh, I have missed that header. Adding <cstdlib> sounds like the
right solution, can you submit a patch or directly commit to SVN if it works for
you?
>
> I added <cstdlib> to api.cpp, interface.cpp and rtl.cpp, in r322869. 
Hans, could you please merge it to release_60, or shall I do it?
Go ahead if you're set up, otherwise let me know and I'll do it.