Kuba Brecka via llvm-dev
2016-Sep-14 17:18 UTC
[llvm-dev] Comments sent via mail are not imported into Phabricator web
Hi Manuel, I believe you're maintaining Phabricator at reviews.llvm.org <http://reviews.llvm.org/>. Duncan likes to send his patch comments via email, like in the example below. Do you know why don't his replies get imported into the web interface? The reply was sent to "reviews+D24569+public+a5763c0a090df06f at reviews.llvm.org <mailto:reviews+D24569+public+a5763c0a090df06f at reviews.llvm.org>", and I bet that the purpose of this weird address is to match the revision this reply belongs to. I never saw any email reply actually appear in the web interface, and that sounds like a server misconfiguration. Or is that something that Phabricator just doesn't support? Thanks, Kuba> Begin forwarded message: > > From: "Duncan P. N. Exon Smith" <dexonsmith at apple.com> > Subject: Re: [PATCH] D24569: [libcxx] Allow sanitizing libcxx with ASan+UBSan simultaneously > Date: 14 September 2016 at 19:01:29 GMT+2 > To: reviews+D24569+public+a5763c0a090df06f at reviews.llvm.org > Cc: kuba.brecka at gmail.com, eric at efcs.ca, compnerd at compnerd.org, filcab+llvm.phabricator at gmail.com, beanz at apple.com, zaks.anna at gmail.com, mgorny at gentoo.org > > >> On 2016-Sep-14, at 09:39, Kuba Brecka <kuba.brecka at gmail.com> wrote: >> >> kubabrecka added inline comments. >> >> ===============>> Comment at: test/libcxx/test/config.py:628 >> @@ +627,3 @@ >> + self.cxx.flags += ['-fsanitize=undefined', > > Shouldn't this be '-fsanitize="undefined;address"'? > >> + '-fno-sanitize=vptr,function,float-divide-by-zero', >> + '-fno-sanitize-recover=all'] > > Can this be refactored to avoid code duplication with the UBSan changes?-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160914/4c6331cb/attachment.html>
Manuel Klimek via llvm-dev
2016-Sep-14 17:20 UTC
[llvm-dev] Comments sent via mail are not imported into Phabricator web
On Wed, Sep 14, 2016 at 10:18 AM Kuba Brecka <kuba.brecka at gmail.com> wrote:> Hi Manuel, > > I believe you're maintaining Phabricator at reviews.llvm.org. Duncan > likes to send his patch comments via email, like in the example below. Do > you know why don't his replies get imported into the web interface? The > reply was sent to "reviews+D24569+public+a5763c0a090df06f at reviews.llvm.org", > and I bet that the purpose of this weird address is to match the revision > this reply belongs to. I never saw any email reply actually appear in the > web interface, and that sounds like a server misconfiguration. > > Or is that something that Phabricator just doesn't support? >Correct, phab doesn't support in-line replies. Would be great to add it, but it's quite a bit of development work. Generally, email is the system of record, and phab exists to make email based reviews more convenient.> > Thanks, > Kuba > > Begin forwarded message: > > *From: *"Duncan P. N. Exon Smith" <dexonsmith at apple.com> > *Subject: **Re: [PATCH] D24569: [libcxx] Allow sanitizing libcxx with > ASan+UBSan simultaneously* > *Date: *14 September 2016 at 19:01:29 GMT+2 > *To: *reviews+D24569+public+a5763c0a090df06f at reviews.llvm.org > *Cc: *kuba.brecka at gmail.com, eric at efcs.ca, compnerd at compnerd.org, > filcab+llvm.phabricator at gmail.com, beanz at apple.com, zaks.anna at gmail.com, > mgorny at gentoo.org > > > On 2016-Sep-14, at 09:39, Kuba Brecka <kuba.brecka at gmail.com> wrote: > > kubabrecka added inline comments. > > ===============> Comment at: test/libcxx/test/config.py:628 > @@ +627,3 @@ > + self.cxx.flags += ['-fsanitize=undefined', > > > Shouldn't this be '-fsanitize="undefined;address"'? > > + > '-fno-sanitize=vptr,function,float-divide-by-zero', > + '-fno-sanitize-recover=all'] > > > Can this be refactored to avoid code duplication with the UBSan changes? > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160914/b8da959f/attachment.html>
Reid Kleckner via llvm-dev
2016-Sep-14 17:24 UTC
[llvm-dev] Comments sent via mail are not imported into Phabricator web
On Wed, Sep 14, 2016 at 10:20 AM, Manuel Klimek via llvm-dev < llvm-dev at lists.llvm.org> wrote:> On Wed, Sep 14, 2016 at 10:18 AM Kuba Brecka <kuba.brecka at gmail.com> > wrote: > >> Hi Manuel, >> >> I believe you're maintaining Phabricator at reviews.llvm.org. Duncan >> likes to send his patch comments via email, like in the example below. Do >> you know why don't his replies get imported into the web interface? The >> reply was sent to "reviews+D24569+public+a5763c0a090df06f at reviews.llvm. >> org", and I bet that the purpose of this weird address is to match the >> revision this reply belongs to. I never saw any email reply actually >> appear in the web interface, and that sounds like a server misconfiguration. >> >> Or is that something that Phabricator just doesn't support? >> > > Correct, phab doesn't support in-line replies. Would be great to add it, > but it's quite a bit of development work. > Generally, email is the system of record, and phab exists to make email > based reviews more convenient. >I filed this as https://llvm.org/bugs/show_bug.cgi?id=29038. I thought at one point you could cc reviews+... at reviews.llvm.org to add whole issue comments (not inline replies), but it doesn't seem to work for me anymore. Whatever happens, I'd like to document what is supposed to happen when you reply by email to a phab review at http://llvm.org/docs/Phabricator.html. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160914/ed85727e/attachment.html>