llvm dev - Oct 2012 - [LLVMdev] [cfe-commits] [PATCH/RFC, PowerPC] Extend 32-bit function arguments / return values

Rafael Espíndola <rafael.espindola at gmail.com> wrote on 23.10.2012
15:54:47:
> > Well, I guess the "exact triple" would specify Intel, right?
In which
> > case the IR wouldn't really have to change ...
> >
> > However, this would mean a whole bunch of test cases either
wouldn't
> > be executed at all on non-Intel platforms, or else we'd have to
have
> > (near-)duplicates of the tests for different platforms.  Neither
option
> > looks really desirable to me.
>
> There are not that many tests and they are not very platform
> dependent, so I don't thing you are losing too much by adding a triple
> to them.
Well, fine with me.  I can prepare a patch to add the triple.

Which triple would you suggest to use for this?

i386-apple-darwin  ?
i386-pc-linux-gnu  ?
i386-unknown-unknown  ?

(I don't have Darwin systems to test on myself.  I could test either of
the latter on Linux/Intel ...)

Thanks,
Ulrich

> Which triple would you suggest to use for this?
>
> i386-apple-darwin  ?
> i386-pc-linux-gnu  ?
> i386-unknown-unknown  ?
>
> (I don't have Darwin systems to test on myself.  I could test either of
> the latter on Linux/Intel ...)
If they pass with i386-unknown-unknown, that is probably the best.
> Thanks,
> Ulrich
>
Thanks,
Rafael

Rafael Espíndola <rafael.espindola at gmail.com> wrote on 23.10.2012
18:00:36:
> > Which triple would you suggest to use for this?
> >
> > i386-apple-darwin  ?
> > i386-pc-linux-gnu  ?
> > i386-unknown-unknown  ?
> >
> > (I don't have Darwin systems to test on myself.  I could test
either of
> > the latter on Linux/Intel ...)
>
> If they pass with i386-unknown-unknown, that is probably the best.
OK, the appended patch implements this.  All tests pass (both on a
PowerPC-Linux and a Intel-Linux host), and continue passing with my
original ppc64 ABI patch added, as expected.

Bye,
Ulrich

(See attached file: diff-clang-ppc64-extend-testfixes)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-clang-ppc64-extend-testfixes
Type: application/octet-stream
Size: 11426 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121023/9f5e0439/attachment.obj>