On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords <blunted2night at gmail.com> wrote:> write_uint32_le is used to write into a arbitrary data buffer, where as > WriteLE32 is used to write into the object file.Ah, I didn't notice that. Here's yet another style patch. Thanks to coppro for the review that found most of these. (note, I made a branch and did a rebase just so I could merge all the changes into one commit for the sexy github diff display :P. Switch to master if you want to pull). http://github.com/Bigcheese/llvm-mirror/commit/9e44816f67d80cf0a5572f0302573ec73182fcd5 Up next are the more substantial changes; starting with splitting up WinCOFF.h into Support/COFF.h and WinCOFFObjectWriter. - Michael Spencer
Right on, thanks for working on this. I have been busy lately, but its good to see progress being made. On Mon, Jun 21, 2010 at 11:31 PM, Michael Spencer <bigcheesegs at gmail.com>wrote:> On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > write_uint32_le is used to write into a arbitrary data buffer, where as > > WriteLE32 is used to write into the object file. > > Ah, I didn't notice that. > > Here's yet another style patch. Thanks to coppro for the review that > found most of these. (note, I made a branch and did a rebase just so I > could merge all the changes into one commit for the sexy github diff > display :P. Switch to master if you want to pull). > > > http://github.com/Bigcheese/llvm-mirror/commit/9e44816f67d80cf0a5572f0302573ec73182fcd5 > > Up next are the more substantial changes; starting with splitting up > WinCOFF.h into Support/COFF.h and WinCOFFObjectWriter. > > - Michael Spencer >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100621/48400649/attachment.html>
I just finished the initial split up of WinCOFF.h into llvm/Support/COFF.h and lib/MC/WinCOFFObjectWriter.cpp. This includes almost the minimum changes required to split them up. WinCOFFObjectWriter now needs some refactoring to make things more consistent and less verbose. There also seem to be quite a few memory leaks that need to be resolved. http://github.com/Bigcheese/llvm-mirror/commit/a6f207e2a9b04e1c82c949e207b8f420535e3c2f (still passes the test) Any ideas for refactoring this are welcome. I have some ideas for refactoring, but I would feel a lot better about making any major changes if I had some outside input. I'm now going to make the stub patches that Daniel requested. - Michael Spencer