search for: write_uint32_l

On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> wrote: > > Whats going on with having both write_uint32_le() > in WinCOFFObjectWriter::DefineSection() and WriteLE32() in > WinCOFFObjectWriter::WriteFileHeader() ? > Aaron Thanks, missed that one. Nathan used write_uint32_le in WinCOFF.h, and I guess accidentally used it in WinCOFFObjectWriter.cpp. I'll remove the calls from WinCOFFObjectWr...

write_uint32_le is used to write into a arbitrary data buffer, where as WriteLE32 is used to write into the object file. On Mon, Jun 21, 2010 at 9:01 AM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> > wrote: &gt...

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next part --------------

On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > write_uint32_le is used to write into a arbitrary data buffer, where as >  WriteLE32 is used to write into the object file. Ah, I didn't notice that. Here's yet another style patch. Thanks to coppro for the review that found most of these. (note, I made a branch and did a rebase just so I could merge...

...-*-===// +// A terminology question: is it "Win32 COFF" file or "PECOFF" file? What is the difference? What does Win64 use? +#include <stdio.h> Do you really need this? If so, please use <cstdio> + assert (Section->Symbol->Aux.size () == 15); + write_uint32_le(Section->Symbol->Aux.data() + 0, Section->Header.SizeOfRawData); + write_uint16_le(Section->Symbol->Aux.data() + 4, Section->Header.NumberOfRelocations); + write_uint16_le(Section->Symbol->Aux.data() + 6, Section->Header.PointerToLineNumbers); ... + void add_com...

Here is a full patch including Nathan's COFF support, tests that pass on Windows, and some changes to lit. Obviously the COFF support and changes to lit should be separate patches in the end. http://codereview.appspot.com/1624043/show - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: COFF-support.patch Type: application/octet-stream Size:

...COFF" file or "PECOFF" file? > What is the difference? What does Win64 use? > > > > +#include <stdio.h> > > Do you really need this? If so, please use <cstdio> > > > > + assert (Section->Symbol->Aux.size () == 15); > + write_uint32_le(Section->Symbol->Aux.data() + 0, Section- > >Header.SizeOfRawData); > + write_uint16_le(Section->Symbol->Aux.data() + 4, Section- > >Header.NumberOfRelocations); > + write_uint16_le(Section->Symbol->Aux.data() + 6, Section- > >Header.PointerToLine...

...on, thanks for working on this. I have been busy lately, but its good to see progress being made. On Mon, Jun 21, 2010 at 11:31 PM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > write_uint32_le is used to write into a arbitrary data buffer, where as > > WriteLE32 is used to write into the object file. > > Ah, I didn't notice that. > > Here's yet another style patch. Thanks to coppro for the review that > found most of these. (note, I made a branch and did a...

...What is >> the difference? What does Win64 use? >> >> >> >> +#include <stdio.h> >> >> Do you really need this? If so, please use <cstdio> >> >> >> >> + assert (Section->Symbol->Aux.size () == 15); >> + write_uint32_le(Section->Symbol->Aux.data() + 0, >> Section->Header.SizeOfRawData); >> + write_uint16_le(Section->Symbol->Aux.data() + 4, >> Section->Header.NumberOfRelocations); >> + write_uint16_le(Section->Symbol->Aux.data() + 6, >> Section->Header...