search for: coppro

...n Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > write_uint32_le is used to write into a arbitrary data buffer, where as >  WriteLE32 is used to write into the object file. Ah, I didn't notice that. Here's yet another style patch. Thanks to coppro for the review that found most of these. (note, I made a branch and did a rebase just so I could merge all the changes into one commit for the sexy github diff display :P. Switch to master if you want to pull). http://github.com/Bigcheese/llvm-mirror/commit/9e44816f67d80cf0a5572f0302573ec73182fcd5...

On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> wrote: > > Whats going on with having both write_uint32_le() > in WinCOFFObjectWriter::DefineSection() and WriteLE32() in > WinCOFFObjectWriter::WriteFileHeader() ? > Aaron Thanks, missed that one. Nathan used write_uint32_le in WinCOFF.h, and I guess accidentally used it in WinCOFFObjectWriter.cpp.

write_uint32_le is used to write into a arbitrary data buffer, where as WriteLE32 is used to write into the object file. On Mon, Jun 21, 2010 at 9:01 AM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> > wrote: > > > > Whats going on with having both write_uint32_le() > > in

...athan Jeffords > <blunted2night at gmail.com> wrote: > > write_uint32_le is used to write into a arbitrary data buffer, where as > > WriteLE32 is used to write into the object file. > > Ah, I didn't notice that. > > Here's yet another style patch. Thanks to coppro for the review that > found most of these. (note, I made a branch and did a rebase just so I > could merge all the changes into one commit for the sexy github diff > display :P. Switch to master if you want to pull). > > > http://github.com/Bigcheese/llvm-mirror/commit/9e44816f67d...