search for: wincoff

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next part --------------

...I'm not quite ready to apply this patch, but I now have time again to work on getting it in. The main reason I am not willing to put it in yet is (a) the size, and (b) the inconsistences with LLVM style. Please fix the following things: - Watch out for case mismatches, i.e., #include "WinCoff.h" when the header is actually WinCOFF.h. - The patch doesn't have a consistent newline convention, it is a mix of DOS and Unix. - if( -> if ( - A [1] -> A[1] - Braces go on the same line as if/else. - Please use AddFragment instead of add_fragment, etc, and we tend to only...

On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> wrote: > > Whats going on with having both write_uint32_le() > in WinCOFFObjectWriter::DefineSection() and WriteLE32() in > WinCOFFObjectWriter::WriteFileHeader() ? > Aaron Thanks, missed that one. Nathan used write_uint32_le in WinCOFF.h, and I guess accidentally used it in WinCOFFObjectWriter.cpp. I'll remove the calls from WinCOFFObjectWriter.cpp now, and r...

...write into the object file. On Mon, Jun 21, 2010 at 9:01 AM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> > wrote: > > > > Whats going on with having both write_uint32_le() > > in WinCOFFObjectWriter::DefineSection() and WriteLE32() in > > WinCOFFObjectWriter::WriteFileHeader() ? > > Aaron > > Thanks, missed that one. Nathan used write_uint32_le in WinCOFF.h, and > I guess accidentally used it in WinCOFFObjectWriter.cpp. I'll remove > the calls from WinCO...

...d a rebase just so I could merge all the changes into one commit for the sexy github diff display :P. Switch to master if you want to pull). http://github.com/Bigcheese/llvm-mirror/commit/9e44816f67d80cf0a5572f0302573ec73182fcd5 Up next are the more substantial changes; starting with splitting up WinCOFF.h into Support/COFF.h and WinCOFFObjectWriter. - Michael Spencer

...ction Relative relocations and updats the COFF object writer to write it as COFF_IMAGE_REL_AMD64_SREL32 secrel-streamer.patch adds a new directive in the MCStreamer interface to allow the AsmPrinter to emit a section relative label and provides implementations for all existings Streamer (all but WinCOFF either forward or error on it) secrel-dwarf.patch updates dwarf printing code to make use of the new directive & DIE value where appropriate (this is where the bug fix is) coff-debug.patch turns the dwarf output on in the X86/COFF AsmInfo classes - Nathan -------------- next part -------...

...ve attached the latest version of my > Win32 COFF support patch. There is no new functionality, I just fixed some > compiler errors due to recent changes in the MC library. > > Nathan, Sorry about this but... On Cygwin with GCC-4.2.4 :- In file included from /home/ang/svn/llvm/lib/MC/WinCOFFObjectWriter.cpp:32: /home/ang/svn/llvm/lib/MC/WinCoff.h:68: error: comma at end of enumerator list Otherwise builds okay. I'll run some tests on it... Aaron -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachment...

...all the changes into one commit for the sexy github diff > display :P. Switch to master if you want to pull). > > > http://github.com/Bigcheese/llvm-mirror/commit/9e44816f67d80cf0a5572f0302573ec73182fcd5 > > Up next are the more substantial changes; starting with splitting up > WinCOFF.h into Support/COFF.h and WinCOFFObjectWriter. > > - Michael Spencer > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100621/48400649/attachment.html>

...relocations and updats the COFF object writer to write it as COFF_IMAGE_REL_AMD64_SREL32 > > secrel-streamer.patch > adds a new directive in the MCStreamer interface to allow the AsmPrinter to emit a section relative label and provides implementations for all existings Streamer (all but WinCOFF either forward or error on it) > > secrel-dwarf.patch > updates dwarf printing code to make use of the new directive & DIE value where appropriate (this is where the bug fix is) > > coff-debug.patch > turns the dwarf output on in the X86/COFF AsmInfo classes This patche...

...and updats the COFF object writer to write it as COFF_IMAGE_REL_AMD64_SREL32 >> >> secrel-streamer.patch >> adds a new directive in the MCStreamer interface to allow the AsmPrinter to emit a section relative label and provides implementations for all existings Streamer (all but WinCOFF either forward or error on it) >> >> secrel-dwarf.patch >> updates dwarf printing code to make use of the new directive & DIE value where appropriate (this is where the bug fix is) >> >> coff-debug.patch >> turns the dwarf output on in the X86/COFF AsmInf...

...patch? Here are some comments on the code, can someone update and send the most recent version? I'd like to get this cleaned up applied even if it isn't functionally perfect yet. Thanks! A general comment: for many of these, I only list one instance of a particular issue. +++ lib/MC/WinCOFF.h (working copy) @@ -0,0 +1,327 @@ +//===-- llvm/MC/MCWin32Coff.h -----------------------------------*- C++ -*-===// Please fix the filename in the comment line. +#include <llvm/MC/MCObjectWriter.h> +#include <llvm/ADT/SmallString.h> +#include <llvm/ADT/SmallVector.h> Please us...

Here is a full patch including Nathan's COFF support, tests that pass on Windows, and some changes to lit. Obviously the COFF support and changes to lit should be separate patches in the end. http://codereview.appspot.com/1624043/show - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: COFF-support.patch Type: application/octet-stream Size:

...pdate and send the most recent version? > > I'd like to get this cleaned up applied even if it isn't > functionally perfect yet. > > Thanks! > > > A general comment: for many of these, I only list one instance of a > particular issue. > > > +++ lib/MC/WinCOFF.h (working copy) > @@ -0,0 +1,327 @@ > +//===-- llvm/MC/MCWin32Coff.h -----------------------------------*- > C++ -*-===// > > Please fix the filename in the comment line. > > +#include <llvm/MC/MCObjectWriter.h> > +#include <llvm/ADT/SmallString.h> > +#incl...

For those that are interested, I have attached the latest version of my Win32 COFF support patch. There is no new functionality, I just fixed some compiler errors due to recent changes in the MC library. - Nathan -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100527/23598d23/attachment.html>

I just finished the initial split up of WinCOFF.h into llvm/Support/COFF.h and lib/MC/WinCOFFObjectWriter.cpp. This includes almost the minimum changes required to split them up. WinCOFFObjectWriter now needs some refactoring to make things more consistent and less verbose. There also seem to be quite a few memory leaks that need to be resolved....

...the COFF object writer to write it as COFF_IMAGE_REL_AMD64_SREL32 >>> >>> secrel-streamer.patch >>> adds a new directive in the MCStreamer interface to allow the AsmPrinter to emit a section relative label and provides implementations for all existings Streamer (all but WinCOFF either forward or error on it) >>> >>> secrel-dwarf.patch >>> updates dwarf printing code to make use of the new directive & DIE value where appropriate (this is where the bug fix is) >>> >>> coff-debug.patch >>> turns the dwarf output on...

...> >> I'd like to get this cleaned up applied even if it isn't functionally >> perfect yet. >> >> Thanks! >> >> >> A general comment: for many of these, I only list one instance of a >> particular issue. >> >> >> +++ lib/MC/WinCOFF.h (working copy) >> @@ -0,0 +1,327 @@ >> +//===-- llvm/MC/MCWin32Coff.h -----------------------------------*- C++ >> -*-===// >> >> Please fix the filename in the comment line. >> >> +#include <llvm/MC/MCObjectWriter.h> >> +#include <llvm/ADT...

Hi guys, While trying to get dwarf debugging information to work with Win32 COFF targets, I came across a couple of issues with the current implementation of WinCOFFObjectWriter. Emitting empty section causes debug information to invalid, as the presence of certain debug section implies available information, and emission of labels as symbols confused gdb about the structure of the program. The attached patch allows the WinCOFFObjectWriter to drop empty sectio...

Hi guys, I have attached my patch to support generating win32 COFF object files. I would have posted earlier, but my system drive crashed and I had to rebuild my system; Luckily, my source code was on a secondary drive. I think this would be a good beginning for ongoing support of the COFF object file format and was hoping for some feedback as to whether it was commit worthy or what was needed to