Baole Ni
2016-Aug-02 10:50 UTC
[PATCH 0214/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com> Signed-off-by: Baole Ni <baolex.ni at intel.com> --- drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c index 4150873..1b7bd86 100644 --- a/drivers/gpu/drm/virtio/virtgpu_kms.c +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c @@ -31,7 +31,7 @@ static int virtio_gpu_fbdev = 1; MODULE_PARM_DESC(fbdev, "Disable/Enable framebuffer device & console"); -module_param_named(fbdev, virtio_gpu_fbdev, int, 0400); +module_param_named(fbdev, virtio_gpu_fbdev, int, S_IRUSR); static void virtio_gpu_config_changed_work_func(struct work_struct *work) { -- 2.9.2
Possibly Parallel Threads
- [PATCH 0214/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0202/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0203/1285] Replace numeric parameter like 0444 with macro