Baole Ni
2016-Aug-02 11:42 UTC
[PATCH 0753/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com> Signed-off-by: Baole Ni <baolex.ni at intel.com> --- drivers/net/virtio_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index e0638e5..39815e4 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -30,11 +30,11 @@ #include <net/busy_poll.h> static int napi_weight = NAPI_POLL_WEIGHT; -module_param(napi_weight, int, 0444); +module_param(napi_weight, int, S_IRUSR | S_IRGRP | S_IROTH); static bool csum = true, gso = true; -module_param(csum, bool, 0444); -module_param(gso, bool, 0444); +module_param(csum, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param(gso, bool, S_IRUSR | S_IRGRP | S_IROTH); /* FIXME: MTU in config. */ #define GOOD_PACKET_LEN (ETH_HLEN + VLAN_HLEN + ETH_DATA_LEN) -- 2.9.2
Reasonably Related Threads
- [PATCH 0753/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0095/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0991/1285] Replace numeric parameter like 0444 with macro