Baole Ni
2016-Aug-02 10:49 UTC
[Nouveau] [PATCH 0203/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com> Signed-off-by: Baole Ni <baolex.ni at intel.com> --- drivers/gpu/drm/nouveau/nouveau_chan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c b/drivers/gpu/drm/nouveau/nouveau_chan.c index b1d2527..6036456 100644 --- a/drivers/gpu/drm/nouveau/nouveau_chan.c +++ b/drivers/gpu/drm/nouveau/nouveau_chan.c @@ -43,7 +43,7 @@ MODULE_PARM_DESC(vram_pushbuf, "Create DMA push buffers in VRAM"); int nouveau_vram_pushbuf; -module_param_named(vram_pushbuf, nouveau_vram_pushbuf, int, 0400); +module_param_named(vram_pushbuf, nouveau_vram_pushbuf, int, S_IRUSR); int nouveau_channel_idle(struct nouveau_channel *chan) -- 2.9.2
Seemingly Similar Threads
- [PATCH] drm: Display Nouveau boot options at launch
- [PATCH] module parameters: permissions as defines, readable to everyone
- [PATCH] nouveau: Switch perms from macros to octal notations, module params readable to everyone
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0904/1285] Replace numeric parameter like 0444 with macro