Baole Ni
2016-Aug-02 10:49 UTC
[Nouveau] [PATCH 0202/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com> Signed-off-by: Baole Ni <baolex.ni at intel.com> --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c index a665b78..42ed6f7 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c @@ -40,7 +40,7 @@ MODULE_PARM_DESC(tv_norm, "Default TV norm.\n" "\t\tDefault: PAL\n" "\t\t*NOTE* Ignored for cards with external TV encoders."); static char *nouveau_tv_norm; -module_param_named(tv_norm, nouveau_tv_norm, charp, 0400); +module_param_named(tv_norm, nouveau_tv_norm, charp, S_IRUSR); static uint32_t nv42_tv_sample_load(struct drm_encoder *encoder) { -- 2.9.2
Apparently Analagous Threads
- [PATCH] module parameters: permissions as defines, readable to everyone
- [PATCH] nouveau: Switch perms from macros to octal notations, module params readable to everyone
- [PATCH -next] drm/nouveau/nv04: Use match_string() helper to simplify the code
- [PATCH v2 11/21] drm/nouveau: use match_string() helper
- [PATCH 21/33] drm/nouveau: use match_string() helper