Baole Ni
2016-Aug-02 10:50 UTC
[PATCH 0213/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com> Signed-off-by: Baole Ni <baolex.ni at intel.com> --- drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c index 3cc7afa..d40bc45 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drv.c +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c @@ -38,7 +38,7 @@ static struct drm_driver driver; static int virtio_gpu_modeset = -1; MODULE_PARM_DESC(modeset, "Disable/Enable modesetting"); -module_param_named(modeset, virtio_gpu_modeset, int, 0400); +module_param_named(modeset, virtio_gpu_modeset, int, S_IRUSR); static int virtio_gpu_probe(struct virtio_device *vdev) { -- 2.9.2
Maybe Matching Threads
- [PATCH 0213/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0205/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0204/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0202/1285] Replace numeric parameter like 0444 with macro
- [PATCH 0203/1285] Replace numeric parameter like 0444 with macro