Hi! The MCG_CAP MSR never returns a negative count of available error-reporting banks. Thus make nr_mce_banks unsigned. While here, do some other minor cleanups. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
The file you modify is from upstream Linux, and that''s where this patch belongs. -- Keir On 16/8/07 15:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi! > > The MCG_CAP MSR never returns a negative count of available > error-reporting banks. Thus make nr_mce_banks unsigned. > > While here, do some other minor cleanups. > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thursday 16 August 2007 16:42:37 Keir Fraser wrote:> The file you modify is from upstream Linux, and that''s where this patch > belongs.oh, I have many changes in my queue in files that are from Linux (and also new files, that are not in Linux). They do one thing, that does not belong into Linux (or any other OS): Notifying guests, preferably Dom0. I''m about extracting the least intrusive changes first. We can still push changes into Linux that belong to there. For more information where this is going to, please see the discussion "MCE/MCA concept" on this list. The thread started here: http://lists.xensource.com/archives/html/xen-devel/2007-05/msg01015.html Christoph> > -- Keir > > On 16/8/07 15:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi! > > > > The MCG_CAP MSR never returns a negative count of available > > error-reporting banks. Thus make nr_mce_banks unsigned. > > > > While here, do some other minor cleanups. > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Oh yeah, sure: Xen-specific stuff and the general MCE/MCA reworking that you''re talking about are one thing. But there''s no point in minor fixes and stylistic cleanups going into Xen and bypassing upstream Linux. -- Keir On 16/8/07 16:14, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> On Thursday 16 August 2007 16:42:37 Keir Fraser wrote: >> The file you modify is from upstream Linux, and that''s where this patch >> belongs. > > oh, I have many changes in my queue in files that are from Linux > (and also new files, that are not in Linux). > They do one thing, that does not belong into Linux (or any other OS): > Notifying guests, preferably Dom0. > > I''m about extracting the least intrusive changes first. > We can still push changes into Linux that belong to there. > > For more information where this is going to, please see the > discussion "MCE/MCA concept" on this list. The thread started here: > http://lists.xensource.com/archives/html/xen-devel/2007-05/msg01015.html > > Christoph > >> >> -- Keir >> >> On 16/8/07 15:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote: >>> Hi! >>> >>> The MCG_CAP MSR never returns a negative count of available >>> error-reporting banks. Thus make nr_mce_banks unsigned. >>> >>> While here, do some other minor cleanups. >>> >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
To be fair -- if you posted this as part of a fuller patchset to move us away from Linux-synced files and towards a new fully thought-out method for handling MCA/MCE then I''d have no problems with it (but maybe I would with the patchset as a whole :-). It''s just I see no sense in applying it in isolation. -- Keir On 16/8/07 16:28, "Keir Fraser" <keir@xensource.com> wrote:> Oh yeah, sure: Xen-specific stuff and the general MCE/MCA reworking that > you''re talking about are one thing. But there''s no point in minor fixes and > stylistic cleanups going into Xen and bypassing upstream Linux. > > -- Keir > > On 16/8/07 16:14, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > >> On Thursday 16 August 2007 16:42:37 Keir Fraser wrote: >>> The file you modify is from upstream Linux, and that''s where this patch >>> belongs. >> >> oh, I have many changes in my queue in files that are from Linux >> (and also new files, that are not in Linux). >> They do one thing, that does not belong into Linux (or any other OS): >> Notifying guests, preferably Dom0. >> >> I''m about extracting the least intrusive changes first. >> We can still push changes into Linux that belong to there. >> >> For more information where this is going to, please see the >> discussion "MCE/MCA concept" on this list. The thread started here: >> http://lists.xensource.com/archives/html/xen-devel/2007-05/msg01015.html >> >> Christoph >> >>> >>> -- Keir >>> >>> On 16/8/07 15:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote: >>>> Hi! >>>> >>>> The MCG_CAP MSR never returns a negative count of available >>>> error-reporting banks. Thus make nr_mce_banks unsigned. >>>> >>>> While here, do some other minor cleanups. >>>> >>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> >> >> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel