zfs discuss - Jun 2007 - Bug in "zpool history"

Hi,

I was playing around with NexentaCP and its zfs boot facility. I tried
to figure out how what commands to run and I ran zpool history like
this

# zpool history
2007-06-20.10:19:46 zfs snapshot syspool/rootfs at mysnapshot
2007-06-20.10:20:03 zfs clone syspool/rootfs at mysnapshot syspool/myrootfs
2007-06-20.10:23:21 zfs set bootfs=syspool/myrootfs syspool

As you can see it says I did a "zfs set bootfs=..." even though the
correct command should have been "zpool set bootfs=...". Of course
this is purely cosmetical. I currently don''t have access to a recent
nevada build so I just wonder if this is present there as well.

cheers,
Nickus

-- 
Have a look at my blog for sysadmins!
http://aspiringsysadmin.com

On Jun 21, 2007, at 8:47 AM, Niclas Sodergard wrote:
> Hi,
>
> I was playing around with NexentaCP and its zfs boot facility. I tried
> to figure out how what commands to run and I ran zpool history like
> this
>
> # zpool history
> 2007-06-20.10:19:46 zfs snapshot syspool/rootfs at mysnapshot
> 2007-06-20.10:20:03 zfs clone syspool/rootfs at mysnapshot syspool/ 
> myrootfs
> 2007-06-20.10:23:21 zfs set bootfs=syspool/myrootfs syspool
>
> As you can see it says I did a "zfs set bootfs=..." even though
the
> correct command should have been "zpool set bootfs=...". Of
course
> this is purely cosmetical. I currently don''t have access to a
recent
> nevada build so I just wonder if this is present there as well.
nice catch... i filed:
6572465 ''zpool set bootfs=...'' records history as
''zfs set bootfs=...''

expect a fix today.... simply passing ''FALSE'' instead of
''TRUE'' as
the ''pool'' parameter in zpool_log_history().

eric

On 6/21/07, eric kustarz <eric.kustarz at sun.com> wrote:
> > # zpool history
> > 2007-06-20.10:19:46 zfs snapshot syspool/rootfs at mysnapshot
> > 2007-06-20.10:20:03 zfs clone syspool/rootfs at mysnapshot syspool/
> > myrootfs
> > 2007-06-20.10:23:21 zfs set bootfs=syspool/myrootfs syspool
> >
> > As you can see it says I did a "zfs set bootfs=..." even
though the
> > correct command should have been "zpool set bootfs=...". Of
course
> > this is purely cosmetical. I currently don''t have access to a
recent
> > nevada build so I just wonder if this is present there as well.
>
> nice catch... i filed:
> 6572465 ''zpool set bootfs=...'' records history as
''zfs set bootfs=...''
>
> expect a fix today.... simply passing ''FALSE'' instead of
''TRUE'' as
> the ''pool'' parameter in zpool_log_history().
Great. Thanks.

cheers,
Nickus

-- 
Have a look at my blog for sysadmins!
http://aspiringsysadmin.com