Earl Chew
2012-Jan-06 04:27 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120105/4d7bad52/attachment.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: flac.diff Type: application/octet-stream Size: 584 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120105/4d7bad52/attachment.obj
Erik de Castro Lopo
2012-Feb-02 06:30 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
Earl Chew wrote:> When reading the INDEX from the cue sheet, the format MM:SS:FF format > is disallowed if the sample frequency is not a multiple of 75 because > the index would only be approximate. However, 00:00:00 is _exact_ because > it denotes the start of the track, so allow it as a special case. This > allows metaflac_test.sh to pass.Thanks for this patch Earl, but unfortunately even with this patch in place (and the exit 0 I added the script removed), test_metaflac.sh still fails with: test case43: --import-cuesheet-from... ERROR: metadata does not match expected metaflac-test-files/case43-expect.meta Would be great if you could have another look at this. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Earl Chew
2012-Feb-02 16:50 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
Erik, I'll resync and have another look. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Wednesday, February 1, 2012 10:30:21 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Earl Chew wrote:> When reading the INDEX from the cue sheet, the format MM:SS:FF format > is disallowed if the sample frequency is not a multiple of 75 because > the index would only be approximate. However, 00:00:00 is _exact_ because > it denotes the start of the track, so allow it as a special case. This > allows metaflac_test.sh to pass.Thanks for this patch Earl, but unfortunately even with this patch in place (and the exit 0 I added the script removed), test_metaflac.sh still fails with: ? ? test case43: --import-cuesheet-from... ERROR: metadata does not match ? ? expected metaflac-test-files/case43-expect.meta Would be great if you could have another look at this. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120202/e35c9258/attachment.htm
Josh Coalson
2012-Apr-25 22:23 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
I haven't checked git yet but I hope this patch has not gone in.? I don't like the special case that this is creating. It would be better to allow MM:SS everywhere but I consider that low priority.>________________________________ > From: Earl Chew <earl_chew at yahoo.com> >To: "flac-dev at xiph.org" <flac-dev at xiph.org> >Sent: Thursday, January 5, 2012 8:27 PM >Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion > > >When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass. > > >_______________________________________________ >flac-dev mailing list >flac-dev at xiph.org >http://lists.xiph.org/mailman/listinfo/flac-dev > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120425/62dee43f/attachment.htm
Erik de Castro Lopo
2012-Apr-25 23:30 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
Josh Coalson wrote:> I haven't checked git yet but I hope this patch has not gone in.? I > don't like the special case that this is creating. > > It would be better to allow MM:SS everywhere but I consider that low priority.I modified version of that patch did go in. See the following commits: https://git.xiph.org/?p=flac.git;a=commit;h=19050f74eaa1aa6d609ca065e1a854ada5bb6b4c https://git.xiph.org/?p=flac.git;a=commit;h=7ee908403e8be011b8a7dd3bf511408b40312c2e https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Earl Chew
2012-Apr-26 22:12 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
Josh, I see my name is mentioned in passing ;-) I submitted that patch because I thought it preferable to keep the test harness running. Backing this change out would also entail changing metaflac_test.sh accordingly, which at the time, I was hesitant to do. At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass. I'm ok either way. Earl ________________________________ From: Josh Coalson <xflac at yahoo.com> To: "flac-dev at xiph.org" <flac-dev at xiph.org> Sent: Wednesday, April 25, 2012 3:23:35 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion I haven't checked git yet but I hope this patch has not gone in.? I don't like the special case that this is creating. It would be better to allow MM:SS everywhere but I consider that low priority.>________________________________ > From: Earl Chew <earl_chew at yahoo.com> >To: "flac-dev at xiph.org" <flac-dev at xiph.org> >Sent: Thursday, January 5, 2012 8:27 PM >Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion > > >When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass. > > >_______________________________________________ >flac-dev mailing list >flac-dev at xiph.org >http://lists.xiph.org/mailman/listinfo/flac-dev > > >_______________________________________________ flac-dev mailing list flac-dev at xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120426/581bd453/attachment.htm
Seemingly Similar Threads
- Fix cuesheet.c to allow metaflac_test.sh to run to completion
- Fix cuesheet.c to allow metaflac_test.sh to run to completion
- Fix cuesheet.c to allow metaflac_test.sh to run to completion
- Fix cuesheet.c to allow metaflac_test.sh to run to completion
- Fix cuesheet.c to allow metaflac_test.sh to run to completion