search for: metaflac_test

Josh, I see my name is mentioned in passing ;-) I submitted that patch because I thought it preferable to keep the test harness running. Backing this change out would also entail changing metaflac_test.sh accordingly, which at the time, I was hesitant to do. At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass. I'm ok either way. Earl ________________________________ From: Josh Coalson <xflac at yahoo.com> To: "f...

...ng" mean ? Earl ________________________________ From: Josh Coalson <xflac at yahoo.com> To: Earl Chew <earl_chew at yahoo.com>; "flac-dev at xiph.org" <flac-dev at xiph.org> Sent: Tuesday, May 1, 2012 8:25:34 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Ah, I don't remember but it might have been a negative test that was supposed to give an error when used with the wrong sample rate. Anyway, could you do another patch that updates to general MM:SS handling? >________________________________ > From: Earl Ch...

...>________________________________ > From: Earl Chew <earl_chew at yahoo.com> >To: Josh Coalson <xflac at yahoo.com>; "flac-dev at xiph.org" <flac-dev at xiph.org> >Sent: Thursday, April 26, 2012 3:12 PM >Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion > > >Josh, > > >I see my name is mentioned in passing ;-) > > >I submitted that patch because I thought it preferable to keep the test harness running. > > >Backing this change out would also entail changing metaflac_test.sh accordingly,...

When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120105/4d7bad52/attachment.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: flac.diff Type: application/octet-st...

...is last: false Do you have any more insight ? Earl ________________________________ From: Earl Chew <earl_chew at yahoo.com> To: "flac-dev at xiph.org" <flac-dev at xiph.org> Sent: Thursday, February 2, 2012 8:50:17 AM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Erik, I'll resync and have another look. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Wednesday, February 1, 2012 10:30:21 PM Subject...

...ll resync and have another look. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Wednesday, February 1, 2012 10:30:21 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Earl Chew wrote: > When reading the INDEX from the cue sheet, the format MM:SS:FF format > is disallowed if the sample frequency is not a multiple of 75 because > the index would only be approximate. However, 00:00:00 is _exact_ because > it denotes the start...

...verywhere but I consider that low priority. >________________________________ > From: Earl Chew <earl_chew at yahoo.com> >To: "flac-dev at xiph.org" <flac-dev at xiph.org> >Sent: Thursday, January 5, 2012 8:27 PM >Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion > > >When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it...

Josh Coalson wrote: > I haven't checked git yet but I hope this patch has not gone in.? I > don't like the special case that this is creating. > > It would be better to allow MM:SS everywhere but I consider that low priority. I modified version of that patch did go in. See the following commits:

Earl Chew wrote: > Erik, > > My working view has this as the last commit: > > commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16 > Author: David Schleef <ds at schleef.org> > Date:?? Thu Aug 25 18:40:29 2011 -0700 > > ??? Fix md5 structure clearing in previous commit > > > > Using this, test_metaflac.sh runs cleanly with my cuesheet.c change.