flac dev - May 2012 - Fix cuesheet.c to allow metaflac_test.sh to run to completion

Josh,

I see my name is mentioned in passing ;-)

I submitted that patch because I thought it preferable to keep the test harness
running.

Backing this change out would also entail changing metaflac_test.sh accordingly,
which at the time, I was hesitant to do.
At the time I figured that at some point metaflac_test.sh was passing, so the
code should probably allow it to pass.

I'm ok either way.


Earl



________________________________
 From: Josh Coalson <xflac at yahoo.com>
To: "flac-dev at xiph.org" <flac-dev at xiph.org> 
Sent: Wednesday, April 25, 2012 3:23:35 PM
Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
 

I haven't checked git yet but I hope this patch has not gone in.? I
don't like the special case that this is creating.

It would be better to allow MM:SS everywhere but I consider that low priority.



>________________________________
> From: Earl Chew <earl_chew at yahoo.com>
>To: "flac-dev at xiph.org" <flac-dev at xiph.org> 
>Sent: Thursday, January 5, 2012 8:27 PM
>Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
> 
>
>When reading the INDEX from the cue sheet, the format MM:SS:FF format is
disallowed if the sample frequency is not a multiple of 75 because the index
would only be approximate. However, 00:00:00 is _exact_ because it denotes the
start of the track, so allow it as a special case. This allows metaflac_test.sh
to pass.
>
>
>_______________________________________________
>flac-dev mailing list
>flac-dev at xiph.org
>http://lists.xiph.org/mailman/listinfo/flac-dev
>
>
>
_______________________________________________
flac-dev mailing list
flac-dev at xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120426/581bd453/attachment.htm

Ah, I don't remember but it might have been a negative test that was
supposed to give an error when used with the wrong sample rate.

Anyway, could you do another patch that updates to general MM:SS handling?



>________________________________
> From: Earl Chew <earl_chew at yahoo.com>
>To: Josh Coalson <xflac at yahoo.com>; "flac-dev at
xiph.org" <flac-dev at xiph.org>
>Sent: Thursday, April 26, 2012 3:12 PM
>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
> 
>
>Josh,
>
>
>I see my name is mentioned in passing ;-)
>
>
>I submitted that patch because I thought it preferable to keep the test
harness running.
>
>
>Backing this change out would also entail changing metaflac_test.sh
accordingly, which at the time, I was hesitant to do.
>At the time I figured that at some point metaflac_test.sh was passing, so
the code should probably allow it to pass.
>
>
>I'm ok either way.
>
>
>
>Earl
>
>
>
>________________________________
> From: Josh Coalson <xflac at yahoo.com>
>To: "flac-dev at xiph.org" <flac-dev at xiph.org> 
>Sent: Wednesday, April 25, 2012 3:23:35 PM
>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
> 
>
>I haven't checked git yet but I hope this patch has not gone in.? I
don't like the special case that this is creating.
>
>
>It would be better to allow MM:SS everywhere but I consider that low
priority.
>
>
>
>
>>________________________________
>> From: Earl Chew <earl_chew at yahoo.com>
>>To: "flac-dev at xiph.org" <flac-dev at xiph.org> 
>>Sent: Thursday, January 5, 2012 8:27 PM
>>Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
>> 
>>
>>When reading the INDEX from the cue sheet, the format MM:SS:FF format is
disallowed if the sample frequency is not a multiple of 75 because the index
would only be approximate. However, 00:00:00 is _exact_ because it denotes the
start of the track, so allow it as a special case. This allows metaflac_test.sh
to pass.
>>
>>
>>_______________________________________________
>>flac-dev mailing list
>>flac-dev at xiph.org
>>http://lists.xiph.org/mailman/listinfo/flac-dev
>>
>>
>>
>_______________________________________________
>flac-dev mailing list
>flac-dev at xiph.org
>http://lists.xiph.org/mailman/listinfo/flac-dev
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120501/bd5c1b12/attachment.htm

Josh,

Sure. I can try. Would you give me a more detailed description of the
requirement ?

What exactly does "general MM:SS handling" mean ?

Earl



________________________________
 From: Josh Coalson <xflac at yahoo.com>
To: Earl Chew <earl_chew at yahoo.com>; "flac-dev at xiph.org"
<flac-dev at xiph.org>
Sent: Tuesday, May 1, 2012 8:25:34 PM
Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
 

Ah, I don't remember but it might have been a negative test that was
supposed to give an error when used with the wrong sample rate.

Anyway, could you do another patch that updates to general MM:SS handling?



>________________________________
> From: Earl Chew <earl_chew at yahoo.com>
>To: Josh Coalson <xflac at yahoo.com>; "flac-dev at
xiph.org" <flac-dev at xiph.org>
>Sent: Thursday, April 26, 2012 3:12 PM
>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
> 
>
>Josh,
>
>
>I see my name is mentioned in passing ;-)
>
>
>I submitted that patch because I thought it preferable to keep the test
harness running.
>
>
>Backing this change out would also entail changing metaflac_test.sh
accordingly, which at the time, I was hesitant to do.
>At the time I figured that at some point metaflac_test.sh was passing, so
the code should probably allow it to pass.
>
>
>I'm ok either way.
>
>
>
>Earl
>
>
>
>________________________________
> From: Josh Coalson <xflac at yahoo.com>
>To: "flac-dev at xiph.org" <flac-dev at xiph.org> 
>Sent: Wednesday, April 25, 2012 3:23:35 PM
>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
> 
>
>I haven't checked git yet but I hope this patch has not gone in.? I
don't like the special case that this is creating.
>
>
>It would be better to allow MM:SS everywhere but I consider that low
priority.
>
>
>
>
>>________________________________
>> From: Earl Chew <earl_chew at yahoo.com>
>>To: "flac-dev at xiph.org" <flac-dev at xiph.org> 
>>Sent: Thursday, January 5, 2012 8:27 PM
>>Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
>> 
>>
>>When reading the INDEX from the cue sheet, the format MM:SS:FF format is
disallowed if the sample frequency is not a multiple of 75 because the index
would only be approximate. However, 00:00:00 is _exact_ because it denotes the
start of the track, so allow it as a special case. This allows metaflac_test.sh
to pass.
>>
>>
>>_______________________________________________
>>flac-dev mailing list
>>flac-dev at xiph.org
>>http://lists.xiph.org/mailman/listinfo/flac-dev
>>
>>
>>
>_______________________________________________
>flac-dev mailing list
>flac-dev at xiph.org
>http://lists.xiph.org/mailman/listinfo/flac-dev
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120502/ac957e03/attachment.htm