similar to: Fix cuesheet.c to allow metaflac_test.sh to run to completion

Erik, I'll resync and have another look. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Wednesday, February 1, 2012 10:30:21 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Earl Chew wrote: > When reading the INDEX

Josh, I see my name is mentioned in passing ;-) I submitted that patch because I thought it preferable to keep the test harness running. Backing this change out would also entail changing metaflac_test.sh accordingly, which at the time, I was hesitant to do. At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass. I'm ok either

Josh, Sure. I can try. Would you give me a more detailed description of the requirement ? What exactly does "general MM:SS handling" mean ? Earl ________________________________ From: Josh Coalson <xflac at yahoo.com> To: Earl Chew <earl_chew at yahoo.com>; "flac-dev at xiph.org" <flac-dev at xiph.org> Sent: Tuesday, May 1, 2012 8:25:34 PM Subject: Re:

Erik, My working view has this as the last commit: commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16 Author: David Schleef <ds at schleef.org> Date:?? Thu Aug 25 18:40:29 2011 -0700 ??? Fix md5 structure clearing in previous commit Using this, test_metaflac.sh runs cleanly with my cuesheet.c change. I set up another view using HEAD at git.xiph.org, and in this other view

Ah, I don't remember but it might have been a negative test that was supposed to give an error when used with the wrong sample rate. Anyway, could you do another patch that updates to general MM:SS handling? >________________________________ > From: Earl Chew <earl_chew at yahoo.com> >To: Josh Coalson <xflac at yahoo.com>; "flac-dev at xiph.org" <flac-dev

I haven't checked git yet but I hope this patch has not gone in.? I don't like the special case that this is creating. It would be better to allow MM:SS everywhere but I consider that low priority. >________________________________ > From: Earl Chew <earl_chew at yahoo.com> >To: "flac-dev at xiph.org" <flac-dev at xiph.org> >Sent: Thursday, January

Josh Coalson wrote: > I haven't checked git yet but I hope this patch has not gone in.? I > don't like the special case that this is creating. > > It would be better to allow MM:SS everywhere but I consider that low priority. I modified version of that patch did go in. See the following commits:

Earl Chew wrote: > Erik, > > My working view has this as the last commit: > > commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16 > Author: David Schleef <ds at schleef.org> > Date:?? Thu Aug 25 18:40:29 2011 -0700 > > ??? Fix md5 structure clearing in previous commit > > > > Using this, test_metaflac.sh runs cleanly with my cuesheet.c change.

The test is rather simple, and only compares the computed output values for a 1kHz signal at the known filter table sampling frequencies with previously obained golden values. As such, the test only verifies that the performance of the replay gain analyser has not changed. A better test would be to compare the computed value with an independently obtain theorectical value. This is possible by

Erik ? ? Testing FLAC file with unknown metadata... OK ? ? ./test_metaflac.sh: line 450: syntax error near unexpected token `then' ? ? ./test_metaflac.sh: line 450: `? then' Do both /bin/bash and /bin/dash give exactly the same error message ? Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew

Earl Chew wrote: > That being said, I think my patch leaves us better off than before ! I agree. We will add it as it is and then tweak futher as needed. Earl, would you be able to update your patch so that it applies against the current git master? Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

Copy additional filter values from Foobar2000 as found in <http://code.google.com/p/sirens2/source/browse/trunk/libwavpack-4.32.psp/wvgain.c?r=32> to allow metaflac to perform gain analysis on high sample rate audio. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120107/018c821b/attachment-0001.htm

Earl Chew wrote: > One per filter table entry. That's 12 files right now. Thats probably a bit much. > The files could be generated on the fly, but that would either require > another program or script (eg Perl), Anything but Perl. I can write Perl but I can't read it :-). > or a dependence on an external toolkit such as sox. I'd be ok with requiring sox to run the

Earl Chew wrote: > I'm a little reluctant to introduce another compiled program when there are > so many other options that will work well enough out of the box. > > Here are two ideas: > > 1. Use bc(1) to compute the raw samples > 2. Use perl(1) to compute the raw samples > > To generate raw unsigned samples using bc(1) for example: > > samplerate = 1000;

Erik, I'm using bash.? Before I alter the syntax, what shell are you using ? Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Sunday, March 11, 2012 3:16:11 AM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote: > There is

Erik, I suspect /bin/sh being dash is what is causing the problem. I will rework the syntax. Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew <earl_chew at yahoo.com> Sent: Sunday, March 11, 2012 10:59:50 PM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote:

Erik, I cannot reproduce the problem you see with either dash(1) or bash(1). > test case62: --import-picture-from... OK > Testing FLAC file with unknown metadata... OK > Testing FLAC replaygain 8000 (8000 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 12000 (12000 x 1) ... OK >

This implementation uses decimation to generate an estimate of the required ReplayGain adjustment for tracks sampled at high rates. This approach avoids having to generate filters with commensurately more taps, and also the subsequent effect on performance as these additional taps are evaluated for high sample rate tracks. Filter table entries with coefficients that are unchanged are marked /*

--- smoerk <smoerk@gmx.de> wrote: > good idea, i'm always putting *.cue files to the directory with the > ripped audio files. but it would prefer one file per song and not one > big file for the whole cd. My vision of how the players should work is this: - make one album.flac with CUESHEET - player loads album.flac, sees CUESHEET, calculates CDDB id (or CDindex, or custom

(Apologies if I'm in the wrong place for this...) I'm trying to use the abcde program to archive CDs to flac files. (Each CD to 1 file, and ultimately multi-disk performances to 1 file.) It extracts the audio to a .flac file and creates a cue sheet with track names & locations. However, when it tries to run metaflac with the --import-cuesheet-from option, it core dumps. I'm