Nut upsdev - Mar 2015 - On ups.status CHRG/DISCHRG Vs battery.charger.status

Hi NUT developers,

part of the 2.7.3 release, we are about to merge the below branch / PR for
the bcmxcp drivers family:
https://github.com/networkupstools/nut/pull/158
https://github.com/networkupstools/nut/tree/pull_158_bcmxcp_rebased

It has introduced the battery.charger.status variable, which is something I
wanted to implement since around 2007.

However, while considering a similar implementation for usbhid-ups, and
thinking a bit more broadly, this new variable tends to collide with the
CHRG / DISCHRG status bits from ups.status, and adding 2 more (floating and
resting).

There, we have 2 options:
1) Keep the legacy CHRG / DISCHRG status bits for ups.status, along with
the complementary ones for battery.charger.status. And advocate (document)
for the use of / switch to the latter, that is more suitable for publishing
such information. All that with an impact on all the NUT driver, and a
transition period to address that cleanly.
2) Add the 2 other status bits (FLOATING and RESTING) for ups.status, still
along with the same new ones for battery.charger.status

I'm personally more in favor of (1), but the long history of NUT makes that
(2) would probably be more suitable. An hybrid approach could also be:
apply (2) (new status bits), and apply the transition of (1).

Feedback and comments warmly welcome.
Going to also push this comment on the PR #158, for the sake of completion.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150325/42712bff/attachment.html>

On Mar 25, 2015, at 4:11 AM, Arnaud Quette <arnaud.quette at gmail.com>
wrote:
> 1) Keep the legacy CHRG / DISCHRG status bits for ups.status, along with
the complementary ones for battery.charger.status. And advocate (document) for
the use of / switch to the latter, that is more suitable for publishing such
information. All that with an impact on all the NUT driver, and a transition
period to address that cleanly.
I prefer this option, for what it's worth. Let's not make ups.status
more cluttered.

-- 
Charles Lepple
clepple at gmail

Hi Charles,

2015-03-29 0:44 GMT+01:00 Charles Lepple <clepple at gmail.com>:
> On Mar 25, 2015, at 4:11 AM, Arnaud Quette <arnaud.quette at
gmail.com>
> wrote:
>
> > 1) Keep the legacy CHRG / DISCHRG status bits for ups.status, along
with
> the complementary ones for battery.charger.status. And advocate (document)
> for the use of / switch to the latter, that is more suitable for publishing
> such information. All that with an impact on all the NUT driver, and a
> transition period to address that cleanly.
>
> I prefer this option, for what it's worth. Let's not make
ups.status more
> cluttered.
>
so do I.
FYI, the patch I committed for ABM use either one or the other.
I.e., if ABM support is enabled, status are published on
battery.charger.status and CHRG/DISCHRG are not pushed to ups.status.
And conversely if ABM is disabled.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150330/9cc44c30/attachment.html>