llvm dev - Apr 2017 - Question about LLVM Building Error with "-DLLVM_ENABLE_DUMP" and "RelWithDebInfo"

Hi All,

I have tried to build llvm tip as following:

cmake -DCMAKE_CXX_FLAGS:STRING="-DLLVM_ENABLE_DUMP" 
-DCMAKE_BUILD_TYPE=RelWithDebInfo ../llvm

After running 'make', I have got error messages like below.

llvm/lib/CodeGen/MachineRegisterInfo.cpp:462:67: error: no ‘void 
llvm::MachineRegisterInfo::dumpUses(unsigned int) const’ member function 
declared in class ‘llvm::MachineRegisterInfo’

llvm/lib/CodeGen/MachineScheduler.cpp:2331:57: error: no ‘void 
llvm::SchedBoundary::dumpScheduledState()’ member function declared in 
class ‘llvm::SchedBoundary’

...

It seems the "defined(LLVM_ENABLE_DUMP)" is needed on several
locations.
How do you think about it? I have attached the diff file about the 
locations for reference.  If I missed something, please let me know.

Thanks,

JinGu Kang

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dump.diff
Type: text/x-patch
Size: 2749 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170406/af650ed2/attachment.bin>

>
> llvm/lib/CodeGen/MachineRegisterInfo.cpp:462:67: error: no ‘void
> llvm::MachineRegisterInfo::dumpUses(unsigned int) const’ member function
> declared in class ‘llvm::MachineRegisterInfo’
>
> llvm/lib/CodeGen/MachineScheduler.cpp:2331:57: error: no ‘void
> llvm::SchedBoundary::dumpScheduledState()’ member function declared in
> class ‘llvm::SchedBoundary’
>

​I see above two already have the fix,

  -
http://llvm.org/doxygen/classllvm_1_1MachineRegisterInfo.html#afcaec6980e5e4b5e2f6214ef37c4bf49
  -
http://llvm.org/doxygen/classllvm_1_1SchedBoundary.html#aaf3d8bc3db8879a5e242fa15f18b72d8
  ​
​Are the remaining issues still there? If so, I think you can just send
patch to Phabricator [1].
​
​[1] https://reviews.llvm.org/​

​Cheers,
chenwj​

--
Wei-Ren Chen (陳韋任)
Homepage: https://people.cs.nctu.edu.tw/~chenwj
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170408/0cf64ef5/attachment.html>

I think the idea is to keep NDEBUG out of headers when possible. So I think this
should better be something like:

-#ifndef NDEBUG
   void dumpUses(unsigned RegNo) const;
-#endif

to be inline with various other dumpers (like MachineInstr::dump(),
Pass::dump(), ...)

If that works for you please submit a patch to phabricator as described in
http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch

- Matthias
> On Apr 6, 2017, at 7:38 AM, jingu at codeplay.com via llvm-dev <llvm-dev
at lists.llvm.org> wrote:
> 
> Hi All,
> 
> I have tried to build llvm tip as following:
> 
> cmake -DCMAKE_CXX_FLAGS:STRING="-DLLVM_ENABLE_DUMP"
-DCMAKE_BUILD_TYPE=RelWithDebInfo ../llvm
> 
> After running 'make', I have got error messages like below.
> 
> llvm/lib/CodeGen/MachineRegisterInfo.cpp:462:67: error: no ‘void
llvm::MachineRegisterInfo::dumpUses(unsigned int) const’ member function
declared in class ‘llvm::MachineRegisterInfo’
> 
> llvm/lib/CodeGen/MachineScheduler.cpp:2331:57: error: no ‘void
llvm::SchedBoundary::dumpScheduledState()’ member function declared in class
‘llvm::SchedBoundary’
> 
> ...
> 
> It seems the "defined(LLVM_ENABLE_DUMP)" is needed on several
locations. How do you think about it? I have attached the diff file about the
locations for reference.  If I missed something, please let me know.
> 
> Thanks,
> 
> JinGu Kang
> 
> <dump.diff>_______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

Hi Matthias and 陳韋任,

I appreciate your comments. I have submitted patch to 
https://reviews.llvm.org/D31866 accoding to Matthias comment. Please 
review it.

Thanks,

JinGu Kang

On 08/04/2017 00:45, Matthias Braun wrote:
> I think the idea is to keep NDEBUG out of headers when possible. So I think
this should better be something like:
>
> -#ifndef NDEBUG
>     void dumpUses(unsigned RegNo) const;
> -#endif
>
> to be inline with various other dumpers (like MachineInstr::dump(),
Pass::dump(), ...)
>
> If that works for you please submit a patch to phabricator as described in
http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch
>
> - Matthias
>
>> On Apr 6, 2017, at 7:38 AM, jingu at codeplay.com via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>>
>> Hi All,
>>
>> I have tried to build llvm tip as following:
>>
>> cmake -DCMAKE_CXX_FLAGS:STRING="-DLLVM_ENABLE_DUMP"
-DCMAKE_BUILD_TYPE=RelWithDebInfo ../llvm
>>
>> After running 'make', I have got error messages like below.
>>
>> llvm/lib/CodeGen/MachineRegisterInfo.cpp:462:67: error: no ‘void
llvm::MachineRegisterInfo::dumpUses(unsigned int) const’ member function
declared in class ‘llvm::MachineRegisterInfo’
>>
>> llvm/lib/CodeGen/MachineScheduler.cpp:2331:57: error: no ‘void
llvm::SchedBoundary::dumpScheduledState()’ member function declared in class
‘llvm::SchedBoundary’
>>
>> ...
>>
>> It seems the "defined(LLVM_ENABLE_DUMP)" is needed on several
locations. How do you think about it? I have attached the diff file about the
locations for reference.  If I missed something, please let me know.
>>
>> Thanks,
>>
>> JinGu Kang
>>
>> <dump.diff>_______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

> On Apr 7, 2017, at 4:45 PM, Matthias Braun via llvm-dev <llvm-dev at
lists.llvm.org> wrote:
> 
> I think the idea is to keep NDEBUG out of headers when possible. So I think
this should better be something like:
> 
> -#ifndef NDEBUG
>   void dumpUses(unsigned RegNo) const;
> -#endif
> 
> to be inline with various other dumpers (like MachineInstr::dump(),
Pass::dump(), …)
I’m fine with leaving methods there, but we need to be able to compile-out
fields in structure.

We already have ABI_BREAKING_CHECKS for instance to this end, the naming isn’t
completely in line with LLVM_ENABLE_DUMP but could be unified.

— 
Mehdi

> 
> If that works for you please submit a patch to phabricator as described in
http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch
> 
> - Matthias
> 
>> On Apr 6, 2017, at 7:38 AM, jingu at codeplay.com via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>> 
>> Hi All,
>> 
>> I have tried to build llvm tip as following:
>> 
>> cmake -DCMAKE_CXX_FLAGS:STRING="-DLLVM_ENABLE_DUMP"
-DCMAKE_BUILD_TYPE=RelWithDebInfo ../llvm
>> 
>> After running 'make', I have got error messages like below.
>> 
>> llvm/lib/CodeGen/MachineRegisterInfo.cpp:462:67: error: no ‘void
llvm::MachineRegisterInfo::dumpUses(unsigned int) const’ member function
declared in class ‘llvm::MachineRegisterInfo’
>> 
>> llvm/lib/CodeGen/MachineScheduler.cpp:2331:57: error: no ‘void
llvm::SchedBoundary::dumpScheduledState()’ member function declared in class
‘llvm::SchedBoundary’
>> 
>> ...
>> 
>> It seems the "defined(LLVM_ENABLE_DUMP)" is needed on several
locations. How do you think about it? I have attached the diff file about the
locations for reference.  If I missed something, please let me know.
>> 
>> Thanks,
>> 
>> JinGu Kang
>> 
>> <dump.diff>_______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev